Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supportsTransactions to handle whitespace in error, and property state after error #2227

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

Jeffery-Wasty
Copy link
Contributor

@Jeffery-Wasty Jeffery-Wasty commented Oct 3, 2023

Address potential leading whitespace in supportsTransactions error message by adding a trim() to error checking. As well, supportsTransactions should only be true if no error was returned.

lilgreenbird
lilgreenbird previously approved these changes Oct 3, 2023
@lilgreenbird lilgreenbird added this to the 12.5.0 milestone Oct 4, 2023
@Jeffery-Wasty Jeffery-Wasty merged commit b1f7b09 into main Oct 5, 2023
17 checks passed
@Jeffery-Wasty Jeffery-Wasty deleted the supportsTransUpdates branch October 5, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed/Merged PRs
Development

Successfully merging this pull request may close these issues.

Connection.supportsTransactions (still or again?) broken for Azure Synapse "serverless"
3 participants