Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed timestamp string conversion error for cstmt #2449

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Fixed timestamp string conversion error for cstmt #2449

merged 3 commits into from
Jun 18, 2024
+26 −0

Conversation

tkyc
Copy link
Member

@tkyc tkyc commented Jun 11, 2024

Fixes #2436.

@Jeffery-Wasty Jeffery-Wasty added this to the 12.7.1 milestone Jun 11, 2024
Jeffery-Wasty
Jeffery-Wasty reviewed Jun 11, 2024
View reviewed changes
Copy link
Contributor

@Jeffery-Wasty Jeffery-Wasty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, formatter has some suggestions for CallableStatementTest.java.

src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java Outdated Show resolved Hide resolved
src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Jun 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.85%. Comparing base (722c910) to head (fbeb2e9).
Report is 2 commits behind head on main.

❗ Current head fbeb2e9 differs from pull request most recent head 676d7ee

Please upload reports for the commit 676d7ee to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2449      +/-   ##
============================================
+ Coverage     50.13%   50.85%   +0.72%     
- Complexity     3842     3907      +65     
============================================
  Files           145      145              
  Lines         33409    33411       +2     
  Branches       5667     5668       +1     
============================================
+ Hits          16750    16992     +242     
+ Misses        14258    14022     -236     
+ Partials       2401     2397       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tkyc tkyc merged commit 9754078 into main Jun 18, 2024
17 checks passed
@tkyc tkyc deleted the cstmt-timestamp-conversion-fix branch June 18, 2024 21:05
tkyc added a commit that referenced this pull request Jun 19, 2024
@tkyc
Fixed timestamp string conversion error for cstmt (#2449)
4b674e8 
* Fixed timestamp string conversion error for cstmt

* Code review comments p1

* Fixed sproc used in test
This was referenced Jun 19, 2024
Closed
Merged
Jeffery-Wasty added a commit that referenced this pull request Jun 20, 2024
@tkyc @Jeffery-Wasty
Fixed timestamp string conversion error for cstmt (#2449) (#2455)
ee044a8 
* Fixed timestamp string conversion error for cstmt

* Code review comments p1

* Fixed sproc used in test

Co-authored-by: Jeff Wasty <v-jeffwasty@microsoft.com>
@Eng-Fouad Eng-Fouad mentioned this pull request Aug 1, 2024
Merged
@tkyc tkyc mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jeffery-Wasty Jeffery-Wasty Jeffery-Wasty approved these changes

@lilgreenbird lilgreenbird lilgreenbird approved these changes

@barryw-mssql barryw-mssql Awaiting requested review from barryw-mssql

Assignees

@tkyc tkyc

Labels
None yet
Projects
MSSQL JDBC
Status: Closed/Merged PRs
Milestone
12.7.1
3 participants
@tkyc @lilgreenbird @Jeffery-Wasty