Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to compile with AKV v1.0.0 #397

Merged

Conversation

xiangyushawn
Copy link
Contributor

@xiangyushawn xiangyushawn commented Jul 19, 2017

for issue #389

after updating to azure-keyvault v1.0.0, the project breaks. The PR fixes it.

However, it will also break user's existing programs that use AKV. We will need to document this breaking change:

Previous, in order to construct SQLServerColumnEncryptionAzureKeyVaultProvider object, client code needs to construct a SQLServerKeyVaultAuthenticationCallback object first by implementing SQLServerKeyVaultAuthenticationCallback interface (with clientID and clientKey) and also provide an ExecutorService object. By doing so, user needs to handle SQLServerKeyVaultAuthenticationCallback interface and take care of the ExecutorService object (e.g. shutdown) by themselves.

Now, with the latest version of AKV, user can create SQLServerColumnEncryptionAzureKeyVaultProvider object directly with clientID and clientKey. Without implementing interface or providing ExecutorService, it reduces complexity on user side.

SQLServerColumnEncryptionAzureKeyVaultProvider akvProvider = new SQLServerColumnEncryptionAzureKeyVaultProvider(clientID, clientKey);

@xiangyushawn xiangyushawn changed the title Update code to compile with akv v1 Update code to compile with AKV v1.0.0 Jul 19, 2017
@codecov-io
Copy link

codecov-io commented Jul 19, 2017

Codecov Report

Merging #397 into dev will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #397      +/-   ##
============================================
+ Coverage     40.12%   40.16%   +0.04%     
+ Complexity     1890     1888       -2     
============================================
  Files           107      107              
  Lines         24482    24472      -10     
  Branches       4038     4039       +1     
============================================
+ Hits           9823     9830       +7     
+ Misses        12820    12798      -22     
- Partials       1839     1844       +5
Flag Coverage Δ Complexity Δ
#JDBC41 40.07% <0%> (+0.07%) 1884 <0> (+2) ⬆️
#JDBC42 39.97% <0%> (-0.03%) 1880 <0> (-2)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
...QLServerColumnEncryptionAzureKeyVaultProvider.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/KeyVaultCredential.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-1.13%) 16% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 49.43% <0%> (+0.14%) 209% <0%> (-1%) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 45.07% <0%> (+0.2%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fe6ccc...ba4651f. Read the comment docs.

@xiangyushawn xiangyushawn requested a review from AfsanehR-zz July 20, 2017 17:30
@xiangyushawn xiangyushawn merged commit 0d7d78b into microsoft:dev Jul 21, 2017
@xiangyushawn xiangyushawn deleted the update-code-to-compile-with-AKV-v1 branch July 21, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants