Update code to compile with AKV v1.0.0 #397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for issue #389
after updating to azure-keyvault v1.0.0, the project breaks. The PR fixes it.
However, it will also break user's existing programs that use AKV. We will need to document this breaking change:
Previous, in order to construct
SQLServerColumnEncryptionAzureKeyVaultProvider
object, client code needs to construct aSQLServerKeyVaultAuthenticationCallback
object first by implementingSQLServerKeyVaultAuthenticationCallback
interface (withclientID
andclientKey
) and also provide anExecutorService
object. By doing so, user needs to handleSQLServerKeyVaultAuthenticationCallback
interface and take care of theExecutorService
object (e.g. shutdown) by themselves.Now, with the latest version of AKV, user can create
SQLServerColumnEncryptionAzureKeyVaultProvider
object directly withclientID
andclientKey
. Without implementing interface or providingExecutorService
, it reduces complexity on user side.