Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant if/else statements #470

Merged
merged 1 commit into from
Sep 21, 2017

Conversation

JamieMagee
Copy link
Member

Removes redundant if/else statements. For example:

if (foo()) {
   return true;
} else {
   return false;
}

can be simplified to:

return foo();

```
if (foo()) {
   return true;
} else {
   return false;
}
```

can be simplified to:
```
return foo();
```
@codecov-io
Copy link

codecov-io commented Sep 1, 2017

Codecov Report

Merging #470 into dev will decrease coverage by 0.01%.
The diff coverage is 9.09%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #470      +/-   ##
============================================
- Coverage     46.26%   46.25%   -0.02%     
+ Complexity     2201     2197       -4     
============================================
  Files           108      108              
  Lines         25227    25194      -33     
  Branches       4172     4158      -14     
============================================
- Hits          11672    11654      -18     
+ Misses        11538    11525      -13     
+ Partials       2017     2015       -2
Flag Coverage Δ Complexity Δ
#JDBC41 46.03% <9.09%> (-0.04%) 2186 <15> (-6)
#JDBC42 46.12% <9.09%> (+0.01%) 2193 <15> (-4) ⬇️
Impacted Files Coverage Δ Complexity Δ
...va/com/microsoft/sqlserver/jdbc/StreamColumns.java 90.41% <0%> (+1.22%) 22 <8> (ø) ⬇️
...java/com/microsoft/sqlserver/jdbc/StreamError.java 90% <0%> (+4.28%) 8 <1> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/StreamLoginAck.java 76.92% <0%> (+5.49%) 3 <1> (ø) ⬇️
...va/com/microsoft/sqlserver/jdbc/StreamColInfo.java 81.81% <0%> (+3.55%) 6 <1> (ø) ⬇️
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 30.25% <0%> (+0.55%) 49 <0> (ø) ⬇️
.../java/com/microsoft/sqlserver/jdbc/StreamInfo.java 71.42% <0%> (+8.92%) 3 <1> (ø) ⬇️
.../java/com/microsoft/sqlserver/jdbc/StreamSSPI.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../com/microsoft/sqlserver/jdbc/StreamRetStatus.java 71.42% <0%> (+8.92%) 4 <1> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/StreamRetValue.java 81.81% <0%> (+6.81%) 5 <1> (ø) ⬇️
...erverColumnEncryptionCertificateStoreProvider.java 0% <0%> (ø) 0 <0> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a13577...6291ec0. Read the comment docs.

@ajlam ajlam modified the milestone: 6.3.3 Sep 5, 2017
@cheenamalhotra cheenamalhotra merged commit f56f198 into microsoft:dev Sep 21, 2017
@JamieMagee JamieMagee deleted the redundant-if-statement branch September 22, 2017 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants