-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing javax.xml.bind package dependency #485
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #485 +/- ##
============================================
- Coverage 46.37% 46.24% -0.13%
+ Complexity 2212 2203 -9
============================================
Files 108 108
Lines 25231 25230 -1
Branches 4173 4173
============================================
- Hits 11700 11667 -33
- Misses 11524 11555 +31
- Partials 2007 2008 +1
Continue to review full report at Codecov.
|
@@ -4934,7 +4933,7 @@ else if (DataTypes.UNKNOWN_STREAM_LENGTH == dataLength) | |||
isShortValue = columnPair.getValue().precision <= DataTypes.SHORT_VARTYPE_MAX_BYTES; | |||
isNull = (null == currentObject); | |||
if (currentObject instanceof String) | |||
dataLength = isNull ? 0 : (toByteArray(currentObject.toString())).length; | |||
dataLength = isNull ? 0 : (ParameterUtils.HexToBin(currentObject.toString())).length; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for this ParameterUtils
class, are we adding new dependency to the driver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is an existing class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh never mind, it's existing code in the driver
No description provided.