Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing javax.xml.bind package dependency #485

Merged
merged 6 commits into from
Sep 14, 2017

Conversation

AfsanehR-zz
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 11, 2017

Codecov Report

Merging #485 into dev will decrease coverage by 0.12%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #485      +/-   ##
============================================
- Coverage     46.37%   46.24%   -0.13%     
+ Complexity     2212     2203       -9     
============================================
  Files           108      108              
  Lines         25231    25230       -1     
  Branches       4173     4173              
============================================
- Hits          11700    11667      -33     
- Misses        11524    11555      +31     
- Partials       2007     2008       +1
Flag Coverage Δ Complexity Δ
#JDBC41 46.05% <33.33%> (-0.19%) 2187 <0> (-15)
#JDBC42 46.08% <33.33%> (-0.19%) 2200 <0> (-8)
Impacted Files Coverage Δ Complexity Δ
...erverColumnEncryptionCertificateStoreProvider.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.5% <0%> (-0.09%) 0 <0> (ø)
...ver/jdbc/SQLServerAeadAes256CbcHmac256Factory.java 70% <100%> (ø) 4 <0> (ø) ⬇️
...oft/sqlserver/jdbc/SQLServerSymmetricKeyCache.java 57.53% <100%> (ø) 5 <0> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/PLPInputStream.java 53.01% <0%> (-2.41%) 29% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerException.java 75.2% <0%> (-1.66%) 28% <0%> (-1%)
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java 44.94% <0%> (-1.13%) 16% <0%> (-1%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 44.04% <0%> (-0.68%) 103% <0%> (-2%)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 32.81% <0%> (-0.53%) 242% <0%> (-4%)
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java 59.17% <0%> (-0.44%) 88% <0%> (-1%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8960b85...bccfd18. Read the comment docs.

@@ -4934,7 +4933,7 @@ else if (DataTypes.UNKNOWN_STREAM_LENGTH == dataLength)
isShortValue = columnPair.getValue().precision <= DataTypes.SHORT_VARTYPE_MAX_BYTES;
isNull = (null == currentObject);
if (currentObject instanceof String)
dataLength = isNull ? 0 : (toByteArray(currentObject.toString())).length;
dataLength = isNull ? 0 : (ParameterUtils.HexToBin(currentObject.toString())).length;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for this ParameterUtils class, are we adding new dependency to the driver?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is an existing class.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh never mind, it's existing code in the driver

@AfsanehR-zz AfsanehR-zz modified the milestone: 6.3.3 Sep 12, 2017
@AfsanehR-zz AfsanehR-zz merged commit 252159e into microsoft:dev Sep 14, 2017
@AfsanehR-zz AfsanehR-zz deleted the datatypeConverter branch February 2, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants