Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove redundant if/else statements" #505

Merged
merged 1 commit into from
Sep 22, 2017

Conversation

AfsanehR-zz
Copy link
Contributor

Reverting this pr as it caused issues in our internal testing.

Copy link
Member

@cheenamalhotra cheenamalhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamieMagee We are reverting PR due to assert failures in TDSReader. New PR requested for removing reduntant Ifs (avoiding assert statements)

@codecov-io
Copy link

codecov-io commented Sep 22, 2017

Codecov Report

Merging #505 into dev will decrease coverage by 0.07%.
The diff coverage is 3.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #505      +/-   ##
============================================
- Coverage     46.64%   46.57%   -0.08%     
  Complexity     2218     2218              
============================================
  Files           108      108              
  Lines         25279    25312      +33     
  Branches       4167     4181      +14     
============================================
- Hits          11791    11788       -3     
- Misses        11463    11493      +30     
- Partials       2025     2031       +6
Flag Coverage Δ Complexity Δ
#JDBC41 46.34% <3.63%> (-0.07%) 2209 <15> (+4)
#JDBC42 46.46% <3.63%> (ø) 2213 <15> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...va/com/microsoft/sqlserver/jdbc/StreamColumns.java 89.18% <0%> (-1.23%) 22 <8> (ø)
...erverColumnEncryptionCertificateStoreProvider.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...a/com/microsoft/sqlserver/jdbc/StreamLoginAck.java 71.42% <0%> (-5.5%) 3 <1> (ø)
.../java/com/microsoft/sqlserver/jdbc/StreamInfo.java 62.5% <0%> (-8.93%) 3 <1> (ø)
...va/com/microsoft/sqlserver/jdbc/StreamTabName.java 85% <0%> (-4.48%) 7 <1> (ø)
...va/com/microsoft/sqlserver/jdbc/StreamColInfo.java 78.26% <0%> (-3.56%) 6 <1> (ø)
.../java/com/microsoft/sqlserver/jdbc/StreamSSPI.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.22% <0%> (+0.25%) 244 <0> (+2) ⬆️
...java/com/microsoft/sqlserver/jdbc/StreamError.java 85.71% <0%> (-4.29%) 8 <1> (ø)
...soft/sqlserver/jdbc/SQLServerDatabaseMetaData.java 35.59% <0%> (-0.64%) 55 <0> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dfd49...139ea00. Read the comment docs.

@AfsanehR-zz AfsanehR-zz merged commit 0ff826b into dev Sep 22, 2017
@cheenamalhotra cheenamalhotra deleted the revert-470-redundant-if-statement branch September 23, 2017 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants