Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancelTimeout to cancel the query timeout #560

Closed
wants to merge 3 commits into from

Conversation

AfsanehR-zz
Copy link
Contributor

@AfsanehR-zz AfsanehR-zz commented Nov 22, 2017

Added new connection property of cancelQueryTimeout. This will address issue #525 where querytimeout hangs and does not throw exception due to silent dropping of connection.
The driver will wait the total amount of cancelQueryTimeout + queryTimeout to drop the connection and close the channel.

Note: The new connection property of cancelQueryTimeout will be effective only if the queryTimeout is set in the driver.

@codecov-io
Copy link

codecov-io commented Nov 22, 2017

Codecov Report

Merging #560 into dev will decrease coverage by 0.16%.
The diff coverage is 23.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #560      +/-   ##
============================================
- Coverage     46.55%   46.39%   -0.17%     
  Complexity     2226     2226              
============================================
  Files           109      109              
  Lines         25409    25444      +35     
  Branches       4187     4197      +10     
============================================
- Hits          11830    11805      -25     
- Misses        11546    11603      +57     
- Partials       2033     2036       +3
Flag Coverage Δ Complexity Δ
#JDBC42 46.31% <23.68%> (-0.08%) 2223 <1> (+9)
#JDBC43 46.27% <23.68%> (-0.2%) 2218 <1> (-7)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SQLServerResource.java 100% <ø> (ø) 4 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerDataSource.java 45.19% <0%> (-0.48%) 66 <0> (ø)
.../com/microsoft/sqlserver/jdbc/SQLServerDriver.java 76.98% <100%> (+0.12%) 25 <0> (ø) ⬇️
.../microsoft/sqlserver/jdbc/SQLServerConnection.java 45.67% <20%> (-0.16%) 288 <1> (+1)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 53.42% <23.52%> (-0.75%) 0 <0> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java 43.34% <0%> (-1.59%) 104% <0%> (-1%)
...ncurrentlinkedhashmap/ConcurrentLinkedHashMap.java 38.54% <0%> (-0.22%) 42% <0%> (ø)
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 63.02% <0%> (-0.19%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 33.15% <0%> (-0.13%) 243% <0%> (-2%)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9277451...5714ac1. Read the comment docs.

@cheenamalhotra
Copy link
Member

Closing this PR and new PR #674 extended from this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants