Update connectionResiliency branch with the changes from dev branch #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ft#74) * Add connection properties to specify a custom TrustManager Adds two new connection properties that can be used to specify a custom TrustManager implementation: trustManagerClass - Class name of the custom TrustManager trustManagerConstructorArg - Optional argument to pass to the constructor constructor of the custom TrustManager. If encryption is enabled and the trustManagerClass property is specified, it will be retrieved via Class.forName(...). If the optional property trustManagerConstructorArg is specified, then a constructor will be retrieved via getDeclaredConstructors(String.class). The TrustManager will then be instantiated by specified the optional argument as a parameter. If the optional property trustManagerConstructorArg is not specfied, then the default no argument constructor of the class will be retrieved and instantiated. * Adding a few simple test to verify the newly added connection properties * Rename custom trustmanager test package name Previous package name used camel case. Corrects naming to be lower case. * Add missing newlines to trustmanager test classes * Refactor references to trust managers in tests * Refactor whitespace and unneeded extends Object * Add resource cleanup to trust manager tests * Refactor failure handling for trust manager test * Rename tmClazz to tmClass * Add new trust manager properties to SQLServerDataSource * Reword comment * Format custom trustmanager changes with auto formatter
Fix exception thrown by getters on null columns
removing javax.xml.bind package dependency
fix methods that use sp_fkeys
Cleanup travis appveyor
Fix for Classloader leak issue
Remove explicit extends object
Remove redundant if/else statements
Remove unnecessary return statements
…ressions Simplify overly complex boolean expressions
…APIs Removing deprecated APIs in java 9
…nverter Revert "removing javax.xml.bind package dependency "
…_deprecated_APIs Revert "Removing deprecated APIs in java 9"
Replace manual array copying with System.arraycopy().
Calling toString() on a String object is redundant
Replace bare literals with magic constants. For example: `cal.set(1, 1, 577738, 0, 0, 0);` becomes `cal.set(1, Calendar.FEBRUARY, 577738, 0, 0, 0);`
…if-statement Revert "Remove redundant if/else statements"
release process for 6.3.3
Update Appveyor for jdk9
Re-introduce Retry logic for prepared statement caching
…pare to class level declaration to avoid multi-threading issues.
Added needsPrepare Check and removed error code 99586 check
Update changelog and driver version for RTW 6.4 release
Update SNAPSHOT for upcoming preview release.
dev to connres
…v branch (microsoft#540)" This reverts commit 06abd7f.
Update connectionResiliency branch with the changes from dev branch
ulvii
changed the title
Codecov Report
@@ Coverage Diff @@
## connectionResiliency #643 +/- ##
=========================================================
+ Coverage 45.78% 46.2% +0.41%
- Complexity 2225 2239 +14
=========================================================
Files 109 110 +1
Lines 25983 26120 +137
Branches 4332 4347 +15
=========================================================
+ Hits 11897 12069 +172
+ Misses 12006 11963 -43
- Partials 2080 2088 +8
Continue to review full report at Codecov.
|
cheenamalhotra
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few tests disabled, should be addressed when merging this branch to dev.