Usual changes for preview release 6.5.2 #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbae
changed the title
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
| - Updated Maven dependencies for test suite [#676](https://github.com/Microsoft/mssql-jdbc/pull/676) | ||
| - Updated multiple Maven dependency and plugin versions [#688](https://github.com/Microsoft/mssql-jdbc/pull/688) |
There was a problem hiding this comment.
Let's squash "Updated Maven Dependencies" into one line and move the 2 PRs listed in 'Added' here. They're udpates/modifications not something new.
CHANGELOG.md
Outdated
| ### Fixed Issues | ||
| - Fixed an issue where ResultSetMetaData instances created by a ResultSet that has been closed were not persisting [#685](https://github.com/Microsoft/mssql-jdbc/pull/685) | ||
| - Fixed an issue with PreparedStatement.setBigDecimal when no scale is passed [#684](https://github.com/Microsoft/mssql-jdbc/pull/684) | ||
| - Fixed an issue with Statement.setQueryTimeout not throwing an exception when no network is available [#674](https://github.com/Microsoft/mssql-jdbc/pull/674) |
There was a problem hiding this comment.
Please change description for this one. #674 adds new connection property, should be moved to Added Section
ulvii
previously approved these changes
May 4, 2018
CHANGELOG.md
Outdated
| - Fixed an issue where ResultSetMetaData instances created by a ResultSet that has been closed were not persisting [#685](https://github.com/Microsoft/mssql-jdbc/pull/685) | ||
| - Fixed an issue with PreparedStatement.setBigDecimal when no scale is passed [#684](https://github.com/Microsoft/mssql-jdbc/pull/684) | ||
| - Fixed an issue with Statement.setQueryTimeout not throwing an exception when no network is available [#674](https://github.com/Microsoft/mssql-jdbc/pull/674) | ||
| - Fixed an issue with SQLServerDatabaseMetaData having performance degradation in 6.4.0 [#677](https://github.com/Microsoft/mssql-jdbc/pull/677) |
There was a problem hiding this comment.
Please change description to PR title "Improved performance degradation while maintaining JDBC compliance with results from sp_fkeys". Move this one to top of the Fixed Issues List.
Codecov Report
@@ Coverage Diff @@
## dev #692 +/- ##
============================================
- Coverage 48.15% 48.03% -0.12%
+ Complexity 2585 2579 -6
============================================
Files 114 114
Lines 26578 26578
Branches 4453 4453
============================================
- Hits 12798 12768 -30
- Misses 11638 11668 +30
Partials 2142 2142
Continue to review full report at Codecov.
|
cheenamalhotra
approved these changes
May 4, 2018
ulvii
approved these changes
May 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated Gradle / adal4j dependencies as well.