Implement Driver#getParentLogger #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The driver and data source use JUL for logging but do not implement This commit contains the following changes: * implement Driver#getParentLogger * implement DataSource#getParentLogger * use "com.microsoft.sqlserver.jdbc" as the parent logger * instead of spaces and tabs on the same line for indentation use spaces only * remove the comments "The driver currently does not implement JDDBC 4.1 APIs". While technically true these specific methods are implemented now. * follow driver naming conventions rather than Java naming conventions * follow driver conventions modifier location rather than Java conventions * no tests added since I couldn't find any existing tests for the driver oder data source class
|
@marschall the PR is accepted, thanks for your contribution |
lilgreenbird
pushed a commit
to lilgreenbird/mssql-jdbc
that referenced
this pull request
Aug 22, 2020
Remove tenant Id and fix adal issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement getParentLogger
The driver and data source use JUL for logging but do not implement
#getParentLogger.
This commit contains the following changes:
spaces only
"The driver currently does not implement JDDBC 4.1 APIs".
While technically true these specific methods are implemented now.
conventions
driver oder data source class