Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Question in darts _compute_hessian #3044

Closed
hroken opened this issue Oct 29, 2020 · 2 comments · Fixed by #3058
Closed

Question in darts _compute_hessian #3044

hroken opened this issue Oct 29, 2020 · 2 comments · Fixed by #3058
Assignees

Comments

@hroken
Copy link
Contributor

hroken commented Oct 29, 2020

In the darts trainer.py, which function is _compute_hessian, shows :
"hessian = (dalpha { L_trn(w+, alpha) } - dalpha { L_trn(w-, alpha) }) / (2*eps)"
but the below is written by this :
hessian = [(p - n) / 2. * eps for p, n in zip(dalpha_pos, dalpha_neg)]
Is that wrong?

@ultmaster
Copy link
Contributor

Hi @hroken , thanks for your suggestion. I think you are quite right. Could you kindly submit a PR for this?

@hroken
Copy link
Contributor Author

hroken commented Nov 2, 2020

Hi @hroken , thanks for your suggestion. I think you are quite right. Could you kindly submit a PR for this?
Ok,I will try it.

@hroken hroken closed this as completed Nov 3, 2020
@ultmaster ultmaster linked a pull request Nov 3, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants