Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSReference verification of napi_ref #105

Closed
vmoroz opened this issue Apr 19, 2023 · 0 comments · Fixed by #120
Closed

Fix JSReference verification of napi_ref #105

vmoroz opened this issue Apr 19, 2023 · 0 comments · Fixed by #120
Assignees
Labels
bug Something isn't working

Comments

@vmoroz
Copy link
Member

vmoroz commented Apr 19, 2023

The PR #96 broke the validation of napi_ref in JSReference.
Currently it is possible to use napi_ref even if it does not belong to the correct napi_env.
It will cause hard to debug crashes and memory corruptions.
We must fix it to ensure the safety of napi_ref pointers.

@jasongin jasongin added the bug Something isn't working label Apr 21, 2023
@jasongin jasongin moved this to 🔖 Ready in node-api-dotnet tasks Apr 25, 2023
@jasongin jasongin self-assigned this Apr 28, 2023
@jasongin jasongin moved this from 🔖 Ready to 🏗 In progress in node-api-dotnet tasks Apr 28, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in node-api-dotnet tasks Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants