Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document usage of onDidChangeKeyboardLayout function #10

Closed
spoenemann opened this issue Mar 26, 2019 · 3 comments
Closed

Document usage of onDidChangeKeyboardLayout function #10

spoenemann opened this issue Mar 26, 2019 · 3 comments

Comments

@spoenemann
Copy link

Tested on Mac OS 10.14.3 and Windows 10 Build 17134 with NodeJS v8.13.0 and v10.11.0

I try to register a callback function with keymap.onDidChangeKeyboardLayout, but that function is never called.

Here's my test repository:
https://github.com/spoenemann/native-keymap-test

Am I missing something?
@spoenemann spoenemann mentioned this issue Mar 26, 2019
Merged
@alexdima
Copy link
Member

alexdima commented Mar 27, 2019 •
edited
Loading

I have only tested this module in Electron, and in the main process of Electron. I am not sure if it works in vanilla node, as that is a console application and perhaps does not receive the same events from the OS as a GUI application.

@spoenemann
Copy link
Author

I can confirm it works in the Electron main process. This should be documented.

@spoenemann spoenemann changed the title onDidChangeKeyboardLayout does not work Document usage of onDidChangeKeyboardLayout function Mar 29, 2019
@alexdima
Copy link
Member

alexdima commented May 9, 2019

👍 Added section in README.md

@alexdima alexdima closed this as completed May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spoenemann @alexdima