-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS5055 with javascript nodejs project #1356
Comments
This sounds like a TypeScript issue, similar perhaps to microsoft/TypeScript#8837. Can you please go to Thanks. |
@mjbvz yep, same with ntvs 1.2 |
@alanpurple Thanks. To help with the investigation, can you also please provide:
Thanks. |
no errors with newly created ntvs project with express 4.14.0 |
@mjbvz This is because ntvs project is also configured as typescript virtual project, and somehow, it treats every js files as they are typescript files ( and maybe compileOnSave: true by default ) I think this is not a typescript library problem |
I believe our recent change at https://github.com/Microsoft/TypeScript/pull/12118/files should fix this. Will verify... |
@billti I can't wait to install that with "TypeScript for Visual Studio 2015" |
Actually, I just realized that change will only apply to VS Code and VS 2017 (which use tsserver.js from TypeScript). We'll need some changes on the VS side for VS 2015. I'll need to look into this. For now, if you drop a tsconfig.json in the root of your project which looks like the below (assuming you only have JavaScript files and not TypeScript files), that should resolve it. {
"compilerOptions": {
"module": "commonjs",
"allowJs": true,
"noEmit": true,
"target": "es6"
},
"typingOptions": {
"enableAutoDiscovery": true
}
} |
@billti I have ASP.NET project and nodejs project in one solution. When I make tsconfig.json you told, an error came from node_modules/rxjs file, they can't find modules which exist |
I'll need to understand the project structure a little better to understand what might be causing this, if you're mixing project types in a solution. Is there any cross referencing? Did the RxJs error come from the ASP.NET or NTVS project? Where/which project did you put the tsconfig.json file in? etc. If you are able to attach (or email) me some code to repro the problem, that would be really helpful. Is that possible? |
@billti sure, I'll email you anyway this doesn't show anymore in VS2017 RC. no error after modify js file in ntvs project. |
Closing as this appears to be fixed |
Win 10 x64
VS 2015 update3
node.js 6.9.0 x64
ntvs dev 2016. 10.14
TS5055 errors are ocurring with javascript nodejs project
Severity Code Description Project File Line Suppression State
Error TS5055 Cannot write file 'C:/vsworkspace/AdvisorDemo/AdvisorDemoBackend/routes/item-route.js' because it would overwrite input file. TypeScript/JavaScript Virtual Projects 1 Active
The text was updated successfully, but these errors were encountered: