Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong use of CAP_ALLOW in local/o365/classes/observers.php #1400

Closed
darius-m opened this issue Oct 7, 2020 · 1 comment · Fixed by #1404 or #1405
Closed

Wrong use of CAP_ALLOW in local/o365/classes/observers.php #1400

darius-m opened this issue Oct 7, 2020 · 1 comment · Fixed by #1404 or #1405
Assignees
@weilai-irl
Labels
Issue type - bug Bugs in existing code that needs to be fixed.
Milestone
Release 2020-11

Comments

@darius-m
Copy link
Contributor

darius-m commented Oct 7, 2020

A recent commit changed the way team owners are identified by adding the local/o365:teamowner capability.
However, when fetching the roles with the capabilities in local/o365/classes/observers.php, CAP_ALLOW is used as a string instead of a macro.

Pull request #1387 fixes this issue.
@weilai-irl weilai-irl self-assigned this Oct 7, 2020
@weilai-irl weilai-irl added the Issue type - bug Bugs in existing code that needs to be fixed. label Oct 7, 2020
@weilai-irl weilai-irl added this to the Release 2020-11 milestone Oct 7, 2020
This was linked to pull requests Oct 7, 2020
local/o365: Fix observers owner capability checks #1404
Merged
local/o365: Fix observers owner capability checks #1405
Merged
local/o365: Fix observers owner capability checks #1387
Closed
@weilai-irl
Copy link
Collaborator

Hi @darius-m,

Thank you for your contribution. The fix has been included in the latest release 3.8.0.5 and 3.9.2.

Regards,
Lai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weilai-irl weilai-irl

Labels
Issue type - bug Bugs in existing code that needs to be fixed.
Projects
None yet
Milestone
Release 2020-11
2 participants
@weilai-irl @darius-m