Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

PE disassembly can panic #1032

Closed
ranweiler opened this issue Jun 30, 2021 · 0 comments · Fixed by #1034
Closed

PE disassembly can panic #1032

ranweiler opened this issue Jun 30, 2021 · 0 comments · Fixed by #1034
Assignees
Labels
bug Something isn't working

Comments

@ranweiler
Copy link
Member

ranweiler commented Jun 30, 2021

The PE disassembly uses a FixedBitSet to flag coverage feature sites. However, the FixedBitSet::insert() method panics if the bit index is out of bounds.

At a minimum, replace uses of insert() with a non-panicking usage. This doesn't appear to exist, so we could use something like a private extension trait that adds a method like try_insert(&mut self, bit: usize) -> Result<()>.

AB#43103025

@ranweiler ranweiler added the bug Something isn't working label Jun 30, 2021
@ghost ghost added the Needs: triage label Jun 30, 2021
@ranweiler ranweiler self-assigned this Jun 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants