Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

binding user account with email #2085

Closed
scarlett2018 opened this issue Jan 26, 2019 · 15 comments
Closed

binding user account with email #2085

scarlett2018 opened this issue Jan 26, 2019 · 15 comments

Comments

@scarlett2018
Copy link
Member

Currently, user account can not contain "-" and "@", user does not have email address info.

To maintain users email, I have to maintain a table to keep the alias. And some users who start with "v-" cannot have the same user account as their alias.

@fanyangCS
Copy link
Contributor

@yqwang-ms , can we allow "-" and "@" in the user name?

@yqwang-ms
Copy link
Member

yqwang-ms commented Feb 21, 2019

 @ is not allowed, because it is reserved in URI, see https://tools.ietf.org/html/rfc3986#section-2.3
 - is already allowed in YARN Launcher. 
 (For K8S Launcher it is not allowed, because it is already used to sperator in PodName, etc)

@yqwang-ms
Copy link
Member

@fanyangCS
Copy link
Contributor

fanyangCS commented Feb 21, 2019

can we rewrite "@" in the user name to "#"when using it in a uri way?
For k8s launcher, can you change "-" to something else as a separator?

Or maybe we should differentiate "user id" from "user name": the current user name should actually be user id. and we can introduce another field called "user alias" or "email".

@yqwang-ms
Copy link
Member

yqwang-ms commented Feb 21, 2019

But # is also not allowed in URI, URI only allows below, may be we need another one.
ALPHA / DIGIT / "-" / "." / "_" / "~"

For k8s launcher, I keep align with Statefulset who uses -, it is more complex thing we can disscus later given k8s has more strong naming convention on object name, label name, env name.

@Gerhut
Copy link
Member

Gerhut commented Feb 21, 2019

If it just an URI issue, we could encode them.

@yqwang-ms
Copy link
Member

Agree 👍

@fanyangCS
Copy link
Contributor

fanyangCS commented Mar 21, 2019

@Gerhut and @yqwang-ms , with the support of AAD, we should be able to support "-" or "." in user name. This is a must-have now.

@yqwang-ms
Copy link
Member

@scarlett2018
Copy link
Member Author

"-" or "." is already allowed in YARN Launcher.
https://github.com/Microsoft/pai/blob/master/subprojects/frameworklauncher/yarn/doc/USERMANUAL.md#assumption

@yqwang-ms - what else is needed besides YARN Launcher supports?

@yqwang-ms
Copy link
Member

I am not sure, @Gerhut may know the details.

@fanyangCS
Copy link
Contributor

rest server has some constraint. @Gerhut and @wangcan0329 have more information.

@scarlett2018
Copy link
Member Author

cc @xiaowuhu for reference.

@sterowang
Copy link

It seemed the full email address as user name should be supported when we enable Open ID login. From here https://en.wikipedia.org/wiki/Email_address#Local-part we can see a more versatile email address format, so I think our rules might need to be updated.

@scarlett2018
Copy link
Member Author

It seemed the full email address as user name should be supported when we enable Open ID login. From here https://en.wikipedia.org/wiki/Email_address#Local-part we can see a more versatile email address format, so I think our rules might need to be updated.

Thanks @sterowang , seems need to mark this one as higher priority to unblock Open ID login.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants