Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] component test not resetting state fully #14242

Closed
rwoll opened this issue May 18, 2022 · 1 comment
Closed

[BUG] component test not resetting state fully #14242

rwoll opened this issue May 18, 2022 · 1 comment
Assignees
@pavelfeldman

Comments

@rwoll
Copy link
Member

rwoll commented May 18, 2022

See repro here: https://github.com/rwoll/playwright-ct-repro-page-reuse along with commands to run.

Component tests currently re-use the page by default, and it looks like we aren't properly resetting everything, so a dark mode and light mode test are interfering with each other.
@rwoll rwoll added the v1.22 label May 18, 2022
@rwoll
Copy link
Member Author

rwoll commented May 18, 2022

Fixed by #14243

@rwoll rwoll closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavelfeldman pavelfeldman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavelfeldman @rwoll