Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Chromium does not show file chooser dialog #2344

Closed
anonymousaccn opened this issue May 22, 2020 · 8 comments
Closed

[Feature] Chromium does not show file chooser dialog #2344

anonymousaccn opened this issue May 22, 2020 · 8 comments

Comments

@anonymousaccn
Copy link

I would love to see Playwright to support custom executable path for browser. The main reason is in the latest ( at the time I write this message ) version, chromium doesn't support file chooser ( no dialog is opened ) however stable chrome works just fine.

@yury-s
Copy link
Member

yury-s commented May 22, 2020

You can pass custom executablePath as one of the launch options, doe it not work for some reason?

@anonymousaccn
Copy link
Author

Thanks for pointing out, I will try that out.

@dgozman
Copy link
Contributor

dgozman commented May 22, 2020

Note that Playwright is not guaranteed to work correctly with custom browser executable. However, most of the times things should be ok.

@pavelfeldman
Copy link
Member

@anonymousaccn : please don't point to the older Chromium, things won't work there. When you say file chooser is not opened you mean you don't see it in the headless: false mode? That's the new behaviour for Chromium and if you'd like it changed, please let us know. What is your scenario?

@anonymousaccn
Copy link
Author

@pavelfeldman The problem I have with latest playwright if when I use Chromium I got an error called "Failed to fetch ... "
And for Firefox, I got an error regarding network ...
I will post full error when I get home.

And for webkit on windows, file upload dialog is not opened at all, it works on Mac.

@anonymousaccn
Copy link
Author

Note that Playwright is not guaranteed to work correctly with custom browser executable. However, most of the times things should be ok.

Yes, I can see this possible.

@pavelfeldman
Copy link
Member

@anonymousaccn: please let us know what you find - we have all the file chooser tests passing, so it'd be interesting to learn what went wrong. Let me rename the issue.

@pavelfeldman pavelfeldman changed the title [Feature] Set custom browser's executable path [Feature] Chromium does not show file chooser dialog May 26, 2020
@aslushnikov
Copy link
Collaborator

Looks like the discussion here stalled, so closing this.

@anonymousaccn feel free to follow up here or file a new issue, if necessary!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants