Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add preferred browser type to the device types #3728

Closed
mxschmitt opened this issue Sep 2, 2020 · 0 comments · Fixed by #3731
Closed

[Feature] add preferred browser type to the device types #3728

mxschmitt opened this issue Sep 2, 2020 · 0 comments · Fixed by #3731

Comments

@mxschmitt
Copy link
Member

It does mostly make not much sense to test Firefox on an iPhone since on iOS the browser engine is fixed. For Android its not but most of the users attend to use Chromium there.

By that it would be useful to attach the "preferred browser engine" to the browser descriptors. That would be probably:
a) For iOS devices WebKit
b) For Android devices Chromium

Once this feature is implemented we can then allow in the Playwright runner to run a test on Pixel 2 XL and iPhone 11 Pro Max which will then spin up a Chromium and WebKit in the correct resolutions / viewport. Without that change the user has to manually enter his preferred browser.

Reference:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant