You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, I am playing around with playwright at the moment. First impressions is great, I am able to install and run the minimal test on my existing project. I followed the guide in the short readme available here 👉 https://www.npmjs.com/package/playwright-electron
Problem
I am struggling with the typing though, can't seem to get it to work. electron related typing is not available.
It is kinda a deal breaker on my project without the typing so I am really keen to get this to work 😭
Some troubleshooting I did
I was looking at node_modules/playwright-electron/index.d.ts, it looks like it imports the type from playwright-core, however, playwright-core is not in the package.json of playwright-electron
I tried to install playwright-core to get around that, however, I noticed that there is no playwright-core/electron-types available in node_modules/playwright-core/electron-types to be imported from.
Question
Is my above observation correct? in that the typing for electron is indeed missing from the release of playwright-core and therefore can't be found?
Would I be able to get some advice on how to get it to work?
Thanks in advance 🙌
The text was updated successfully, but these errors were encountered:
Thanks for the report, @kevinlinv! I can repro this issue with the latest from npm. Running node packages/build_package.js playwright-electron on tip-of-tree is working correctly, and my guess is that the npm version is slightly outdated. Tagging @pavelfeldman.
As you can probably tell, Playwright support for Electron is new, and we would love to learn more about how it's working for you. Feel free to ping me on Slack/email.
O, good to know it wasn't something I did wrong. Thanks for the help.
As you can probably tell, Playwright support for Electron is new, and we would love to learn more about how it's working for you. Feel free to ping me on Slack/email.
Yep, sounds good, will get in touch with any feedback in the future once I have played with it a little bit more.
Background
Hi, I am playing around with playwright at the moment. First impressions is great, I am able to install and run the minimal test on my existing project. I followed the guide in the short readme available here 👉 https://www.npmjs.com/package/playwright-electron
Problem
I am struggling with the typing though, can't seem to get it to work. electron related typing is not available.
It is kinda a deal breaker on my project without the typing so I am really keen to get this to work 😭
Some troubleshooting I did
I was looking at
node_modules/playwright-electron/index.d.ts
, it looks like it imports the type fromplaywright-core
, however,playwright-core
is not in the package.json ofplaywright-electron
I tried to install
playwright-core
to get around that, however, I noticed that there is noplaywright-core/electron-types
available innode_modules/playwright-core/electron-types
to be imported from.Question
playwright-core
and therefore can't be found?Thanks in advance 🙌
The text was updated successfully, but these errors were encountered: