-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Question] Video Stream #4263
Comments
Hey @nor0x can you share a use case for that? |
in my specific usecase i would want to display a (in the best case live) feed of browser pages. A headful browser is not an option in my case because the view is rendered manually on various platforms |
cc @arjunattam |
Thanks for this @nor0x. Yes, the video feature is built to record and save a file. We could consider providing it as a stream. Does your scenario require cross-browser support? If not, we could explore a Chromium-only workaround to support this scenario. I will move this issue to the main playwright repo, since this is an upstream change. We could use this issue to collect more feedback on this request. |
thanks for the reply @arjunattam - currently Chromium-only would be very fine. Do you have a hint at what code to look at? |
I think eliminating the delays (currently min 100ms) between ScreencastFrame events might be useful. https://chromedevtools.github.io/devtools-protocol/tot/Page/#event-screencastFrame |
@atemiz good idea, i didn't know that there are 100ms between ScreencastFrame events. Just to make sure i get this right - these 100ms are in Chromium or playwright? |
Note that non-Chromium do not have this limitation and stream into vp8. |
@atemiz: thanks for the pointer, I removed the limitation upstream: https://chromium-review.googlesource.com/c/chromium/src/+/2546475, I believe that was a regression. We are still dropping frames based on the backpressure, but it should not be as bad as it used to be. |
thanks for the update @pavelfeldman i will see how i can use this |
Hey @pavelfeldman, another (maybe stupid) question. Chromium uses Skia for rendering, right? |
@nor0x In theory it is possible to expose some other format representing the content being drawn (DisplayList? Maybe even Skia commands list?), but that's not the usecase Playwright focuses on. |
@dgozman alright got it! thanks |
Thank you for reporting this issue and providing comments to those that might be facing a similar problem. I am now closing this as a part of the triage, please feel free to file a new issue with additional details. Given the limited resource and a lot of requests, we need to fulfill most popular requests and at the same time keep our issue database manageable. |
@nor0x I have a similar use case, did you get something working? |
I'm curious also. Any progress on this? |
I'm pretty sure it's not the intended behavior of the newly added video features and
IVideo
, but would it be possible to retrieve a live video stream from a headless browser context, similar to continuous calls topage.ScreenshotAsync
.As far as I understood the new video feature, it's for recording and saving it afterwards?
The text was updated successfully, but these errors were encountered: