Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bundle dlls with Firefox for Windows #4293

Closed
arjunattam opened this issue Oct 30, 2020 · 3 comments · Fixed by #4362
Closed

[BUG] Bundle dlls with Firefox for Windows #4293

arjunattam opened this issue Oct 30, 2020 · 3 comments · Fixed by #4362
Assignees

Comments

@arjunattam
Copy link
Contributor

Follow up of microsoft/playwright-test#181

Firefox throws a missing system dependency for vcruntime140_1.dll. While users can download the visual C++ package to resolve this, we could simplify this as we bundle similar dlls with WebKit on Windows.

@yury-s
Copy link
Member

yury-s commented Nov 5, 2020

Looking more closely into this issue I'm not sure we should bake these dlls into the firefox archive that we ship. We already print instructions that the user should download and install VS C++ redistributable package to fix the dependency which seem safer. Let's discuss this in tomorrow's meeting.

@creage
Copy link

creage commented Nov 2, 2021

This bug started to appear again after upgrading to 1.16.3 from 1.14.1

2021-11-02T10:52:45.2943853Z     browserType.launch: Host system is missing dependencies!
2021-11-02T10:52:45.2944283Z 
2021-11-02T10:52:45.3066450Z 
2021-11-02T10:52:45.3067950Z 
2021-11-02T10:52:45.3188868Z     Some of the Universal C Runtime files cannot be found on the system. You can fix
2021-11-02T10:52:45.3190629Z 
2021-11-02T10:52:45.3365800Z     that by installing Microsoft Visual C++ Redistributable for Visual Studio from:
2021-11-02T10:52:45.3366181Z 
2021-11-02T10:52:45.3529340Z     https://support.microsoft.com/en-us/help/2977003/the-latest-supported-visual-c-downloads
2021-11-02T10:52:45.3530002Z 
2021-11-02T10:52:45.3659950Z 
2021-11-02T10:52:45.3660469Z 
2021-11-02T10:52:45.3812862Z     Full list of missing libraries:
2021-11-02T10:52:45.3815511Z 
2021-11-02T10:52:45.3997757Z         vcruntime140_1.dll

@yury-s Should I create a new issue for it?

@mxschmitt
Copy link
Member

yes @creage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants