Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: pin node to 20.5 to work around https://github.com/nod… #26979

Conversation

mxschmitt
Copy link
Member

…ejs/node/issues/49497 (#26921)"

This reverts commit 874e285.

@mxschmitt mxschmitt marked this pull request as draft September 9, 2023 20:54
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mxschmitt mxschmitt marked this pull request as ready for review September 11, 2023 14:35
@github-actions
Copy link
Contributor

Test results for "tests 1"

5 flaky ⚠️ [chromium] › library/inspector/cli-codegen-python.spec.ts:74:5 › should save the codegen output to a file if specified
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [chromium] › library/tracing.spec.ts:239:5 › should not include trace resources from the previous chunks
⚠️ [chromium] › page/page-event-request.spec.ts:101:3 › should report navigation requests and responses handled by service worker
⚠️ [firefox] › page/page-goto.spec.ts:112:3 › should work with Cross-Origin-Opener-Policy after redirect

25344 passed, 590 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 5811d65 into microsoft:main Sep 11, 2023
28 checks passed
Germandrummer92 pushed a commit to OctoMind-dev/playwright that referenced this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants