From 330f29622dcc919a2322c3643fdea192b8cdc0af Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 30 Sep 2020 18:03:31 -0600 Subject: [PATCH 1/2] test: minor fixes --- test/channels.spec.ts | 2 +- test/downloads-path.spec.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/test/channels.spec.ts b/test/channels.spec.ts index fc1b1abfdf0f1..1222c81f6963c 100644 --- a/test/channels.spec.ts +++ b/test/channels.spec.ts @@ -163,7 +163,7 @@ it('should scope browser handles', async ({browserType, defaultBrowserOptions}) }); it('should work with the domain module', async ({ domain, browserType }) => { - const browser = await browserType.launch(); + const browser = await browserType.launch(defaultBrowserOptions); const page = await browser.newPage(); const result = await page.evaluate(() => 1 + 1); expect(result).toBe(2); diff --git a/test/downloads-path.spec.ts b/test/downloads-path.spec.ts index 55dfd5d3ab5a1..1439135e73940 100644 --- a/test/downloads-path.spec.ts +++ b/test/downloads-path.spec.ts @@ -52,7 +52,7 @@ defineTestFixture('persistentDownloadsContext', async ({server, launchPersistent acceptDownloads: true } ); - page.setContent(`download`); + await page.setContent(`download`); await test(context); await context.close(); }); From 46c1bc932d1a9182a3560abce7b6e8ab119625d2 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 30 Sep 2020 18:09:28 -0600 Subject: [PATCH 2/2] nit --- test/channels.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/channels.spec.ts b/test/channels.spec.ts index 1222c81f6963c..04644f33bb994 100644 --- a/test/channels.spec.ts +++ b/test/channels.spec.ts @@ -162,7 +162,7 @@ it('should scope browser handles', async ({browserType, defaultBrowserOptions}) await expectScopeState(browserType, GOLDEN_PRECONDITION); }); -it('should work with the domain module', async ({ domain, browserType }) => { +it('should work with the domain module', async ({ domain, browserType, defaultBrowserOptions }) => { const browser = await browserType.launch(defaultBrowserOptions); const page = await browser.newPage(); const result = await page.evaluate(() => 1 + 1);