From 0f1211fe5b9c756ebb505d71c605c0306d9ec255 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Fri, 31 Jan 2020 17:03:46 -0800 Subject: [PATCH] fix: do not recommend yarn There's some confusion around Yarn vs Yarn 2 and their interop, which apparently causes some [installation issues](https://stackoverflow.com/questions/59918776/playwright-error-firefox-revision-is-not-downloaded-run-npm-install-or-yarn) --- src/server/chromium.ts | 2 +- src/server/firefox.ts | 2 +- src/server/webkit.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/server/chromium.ts b/src/server/chromium.ts index 89d638d6c018f..9d40da90b6630 100644 --- a/src/server/chromium.ts +++ b/src/server/chromium.ts @@ -248,7 +248,7 @@ export class Chromium implements BrowserType { _resolveExecutablePath(): { executablePath: string; missingText: string | null; } { const browserFetcher = this._createBrowserFetcher(); const revisionInfo = browserFetcher.revisionInfo(); - const missingText = !revisionInfo.local ? `Chromium revision is not downloaded. Run "npm install" or "yarn install"` : null; + const missingText = !revisionInfo.local ? `Chromium revision is not downloaded. Run "npm install"` : null; return { executablePath: revisionInfo.executablePath, missingText }; } } diff --git a/src/server/firefox.ts b/src/server/firefox.ts index 81a07437d42e4..d349ccf6ee84d 100644 --- a/src/server/firefox.ts +++ b/src/server/firefox.ts @@ -227,7 +227,7 @@ export class Firefox implements BrowserType { _resolveExecutablePath() { const browserFetcher = this._createBrowserFetcher(); const revisionInfo = browserFetcher.revisionInfo(); - const missingText = !revisionInfo.local ? `Firefox revision is not downloaded. Run "npm install" or "yarn install"` : null; + const missingText = !revisionInfo.local ? `Firefox revision is not downloaded. Run "npm install"` : null; return { executablePath: revisionInfo.executablePath, missingText }; } } diff --git a/src/server/webkit.ts b/src/server/webkit.ts index f68f57012094c..ecae8464e7647 100644 --- a/src/server/webkit.ts +++ b/src/server/webkit.ts @@ -218,7 +218,7 @@ export class WebKit implements BrowserType { _resolveExecutablePath(): { executablePath: string; missingText: string | null; } { const browserFetcher = this._createBrowserFetcher(); const revisionInfo = browserFetcher.revisionInfo(); - const missingText = !revisionInfo.local ? `WebKit revision is not downloaded. Run "npm install" or "yarn install"` : null; + const missingText = !revisionInfo.local ? `WebKit revision is not downloaded. Run "npm install"` : null; return { executablePath: revisionInfo.executablePath, missingText }; } }