From 3360393d211b2afd166c5877fdebe063b4ab9914 Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 11 Feb 2020 17:39:41 -0800 Subject: [PATCH] feat(active): emulate active state on webkit --- package.json | 2 +- src/webkit/wkPage.ts | 1 + test/emulation.spec.js | 7 ++++++- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index 0833782fbf91d..2e75c7cab39b5 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "playwright": { "chromium_revision": "740289", "firefox_revision": "1025", - "webkit_revision": "1141" + "webkit_revision": "1143" }, "scripts": { "ctest": "cross-env BROWSER=chromium node test/test.js", diff --git a/src/webkit/wkPage.ts b/src/webkit/wkPage.ts index 2b8ee55719b0c..dc11ae65b60fe 100644 --- a/src/webkit/wkPage.ts +++ b/src/webkit/wkPage.ts @@ -68,6 +68,7 @@ export class WKPage implements PageDelegate { private async _initializePageProxySession() { const promises: Promise[] = [ this._pageProxySession.send('Dialog.enable'), + this._pageProxySession.send('Emulation.setActiveAndFocused', { active: true }), this.authenticate(this._page._state.credentials) ]; const contextOptions = this._page.context()._options; diff --git a/test/emulation.spec.js b/test/emulation.spec.js index 468b713faf0d7..330592eec9224 100644 --- a/test/emulation.spec.js +++ b/test/emulation.spec.js @@ -18,7 +18,7 @@ /** * @type {PageTestSuite} */ -module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMIUM, WEBKIT}) { +module.exports.describe = function({testRunner, expect, playwright, headless, FFOX, CHROMIUM, WEBKIT}) { const {describe, xdescribe, fdescribe} = testRunner; const {it, fit, xit, dit} = testRunner; const {beforeAll, beforeEach, afterAll, afterEach} = testRunner; @@ -221,4 +221,9 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI }); }); + describe('focus', function() { + it.skip(!headless)('should think that it is focused by default', async({page}) => { + expect(await page.evaluate('document.hasFocus()')).toBe(true); + }); + }); };