Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate imports: Use more python-like preview #1250

Closed
ThiefMaster opened this issue May 7, 2021 · 5 comments
Closed

Generate imports: Use more python-like preview #1250

ThiefMaster opened this issue May 7, 2021 · 5 comments
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@ThiefMaster
Copy link

image

I would prefer the items in this dropdown to be shown like this:

from indico.web.flask.app import make_app
from indico.modules.categories.controllers.util make_happening_now_func

Ideally with the same syntax highlighting that's used in the editor.

This would make it much more readable than the current way.

@github-actions github-actions bot added the triage label May 7, 2021
@jakebailey
Copy link
Member

Yep, this is on our TODO list; we made completions more consistent but haven't gone and changed these. Quick fixes are trickier because we can't make the "code" bit monospaced, and the quick fix list contains fixes from things that aren't Pylance as well, so we need to have a balance.

My guess is that we can do something like:

Add "from indico.web.flask.app import make_app"
Add "from indico.modules.categories.controllers.util make_happening_now_func"

To clearly indicate the action that will be taken.

@ThiefMaster
Copy link
Author

Lack of monospace sucks :/ Non-monospaced code looks pretty strange. Any idea if I can use custom CSS to make that whole dropdown monospaced? I think I'd prefer that over having nothing in there monospaced...

@jakebailey
Copy link
Member

Not that I'm aware of, anyway. IIRC that's just the system's default text, or whatever Electron preselects. In any case, swapping the order is an improvement anyway, with or without the monospacing (and other languages like TS behave just fine).

@savannahostrowski savannahostrowski added enhancement New feature or request in backlog labels May 10, 2021
@github-actions github-actions bot removed the triage label May 10, 2021
@heejaechang
Copy link
Contributor

we can't do coloring either. the only thing we can do is changing the text to reflect what will be inserted. (same as the one in completion)

@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label May 25, 2021
@jakebailey
Copy link
Member

This issue has been fixed in version 2021.5.4, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202154-26-may-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

4 participants