Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to make a function conform to an overloaded callable protocol #1276

Closed
Azureblade3808 opened this issue May 13, 2021 · 2 comments
Closed
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@Azureblade3808
Copy link

Environment data

  • Language Server version: 2021.5.1
  • OS and version: Windows 7
  • Python version (& distribution if applicable, e.g. Anaconda): 3.8.8 Anaconda

Sample

from __future__ import annotations

from typing import Any, Protocol, overload

class P(Protocol):
    @overload
    def __call__(self, x: int, /) -> int:
        ...

    @overload
    def __call__(self, x: str, /) -> str:
        ...

    def __call__(self, x: Any, /) -> Any:
        ...

def f0(x: Any, /) -> Any:
    return x

a: P = f0

@overload
def f1(x: int, /) -> int:
    ...

@overload
def f1(x: str, /) -> str:
    ...

def f1(x: Any, /) -> Any:
    return x

b: P = f1

Expected behavior

No errors/warnings.

Actual behaviour

Both assignments got warnings.

image

image

@erictraut
Copy link
Contributor

Thanks for the bug report. This will be fixed in the next release.

@erictraut erictraut added bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed needs investigation Could be an issue - needs investigation labels May 14, 2021
@jakebailey
Copy link
Member

This issue has been fixed in version 2021.5.3, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202153-19-may-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants