Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/ or * should not be allowed after *args in function signature #1341

Closed
Azureblade3808 opened this issue May 25, 2021 · 3 comments
Closed

/ or * should not be allowed after *args in function signature #1341

Azureblade3808 opened this issue May 25, 2021 · 3 comments
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@Azureblade3808
Copy link

Environment data

  • Language Server version: 2021.5.3 / 2021.5.4-pre.1
  • OS and version: Windows 7
  • Python version (& distribution if applicable, e.g. Anaconda): 3.8.8 Anaconda

Sample

def f(*args, /, x, *, y):
    ...

Expected behavior

Both / and * get marked as error.

Actual behavior

No errors/warnings.

@erictraut
Copy link
Contributor

Thanks for the feature request. I've added additional checks and corresponding error messages for these cases.

This will be in the next release.

@erictraut erictraut added enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed triage labels May 25, 2021
@Azureblade3808
Copy link
Author

Wow, your speed surprised me.

@jakebailey
Copy link
Member

This issue has been fixed in version 2021.5.4, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202154-26-may-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants