Server crashes with Libzip Error #1397

johntmyers · 2021-06-04T16:10:30Z

Environment data

Language Server version: Pylance language server 2021.6.1-pre.1 (pyright 209c8040) starting
OS and version: Mac OS 11.2.3
Python version (& distribution if applicable, e.g. Anaconda): 3.7.9

Expected behaviour

The server should run

Actual behaviour

The server crashes, and does not properly restart

Logs

[Warn  - 11:50:33 AM] Workspace indexing has hit its upper limit: 2000 files
Background analysis message: getDiagnosticsForRange
Background analysis message: getDiagnosticsForRange
Background analysis message: getDiagnosticsForRange
Background analysis message: getDiagnosticsForRange
Background analysis message: getDiagnosticsForRange
Received updated settings
Libzip Error: Not a zip archive
    at makeLibzipError (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipFS.js:149:29)
    at new m (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipFS.js:121:28)
    at getZipSync (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:784:28)
    at g.makeCallSync (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:665:21)
    at g.existsSync (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:232:21)
    at c.existsSync (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ProxiedFS.js:71:28)
    at r.existsSync (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ProxiedFS.js:71:28)
    at T.existsSync (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/src/common/fileSystem.ts:213:23)
    at t.PyrightFileSystem.existsSync (/Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/src/pyrightFileSystem.ts:63:29)
    at /Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist/pyright-internal/src/analyzer/service.ts:1027:53
[Info  - 12:01:02 PM] Connection to server got closed. Server will restart.
[Error - 12:01:02 PM] Request textDocument/hover failed.
Error: Connection got disposed.
	at Object.dispose (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:59:68124)
	at Object.dispose (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:9:178020)
	at E.handleConnectionClosed (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:9:178232)
	at E.handleConnectionClosed (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:59:21817)
	at t (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:9:176325)
	at invoke (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:9:318740)
	at o.fire (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:9:319501)
	at X (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:59:57486)
	at invoke (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:9:318740)
	at o.fire (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:9:319501)
	at d.fireClose (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:59:47555)
	at ChildProcess.<anonymous> (/Users/jtm/.vscode/extensions/ms-python.python-2021.5.842923320/out/client/extension.js:9:314470)
	at ChildProcess.emit (events.js:327:22)
	at maybeClose (internal/child_process.js:1048:16)
	at Socket.<anonymous> (internal/child_process.js:439:11)
	at Socket.emit (events.js:315:20)
	at Pipe.<anonymous> (net.js:673:12)
[Info  - 12:01:02 PM] Pylance language server 2021.6.1-pre.1 (pyright 209c8040) starting
[Info  - 12:01:02 PM] Server root directory: /Users/jtm/.vscode/extensions/ms-python.vscode-pylance-2021.6.1-pre.1/dist

The text was updated successfully, but these errors were encountered:

jakebailey · 2021-06-04T16:17:39Z

Interesting. Do you have any zip or egg files in your workspace, by chance?

johntmyers · 2021-06-04T16:58:16Z

Yeah, always have because of some of the other tools we use that create various artifacts. This just started happening today though which is weird.

jakebailey · 2021-06-04T17:02:15Z

The latest version of Pylance released on Wednesday adds support for zip/egg files, which the Python interpreter transparently opens when loading modules. That's probably why you're seeing this, and the initial workspace scan goes and explores them. It's likely that one of these files is malformed and we fail to access it.

Perhaps it shouldn't try and do this inside of the workspace (only allowing eggs within site-packages), or at least limit to .egg only to avoid random zip accesses.

(The exists call also should not be throwing, which I can try and work around.)

johntmyers · 2021-06-04T17:16:30Z

Ok, I'm not sure what new files would have gotten into my workspace in the last couple of days for this to stop working today. Also seems odd that the server doesn't actually start back up (contrary to the second to last log line)

erictraut · 2021-06-04T17:20:26Z

I think it's fine for the scan to open zips, but we need to have the appropriate exception handling in place so errors don't crash the language server. If a zip is malformed, we should just catch the exception and ignore the error.

jakebailey · 2021-06-04T17:45:58Z

Yeah, existsSync should never throw, it should just return false (based on my understanding of node's FS module). Clearly the FS abstraction I added to support zips/eggs didn't keep that assumption, so I will fix that.

ducalpha · 2021-06-07T00:49:35Z

I am getting the same problem and I have to downgraded Pylance to 2021.5.4. Is there any workaround available?

Environment data

Language Server version: Pylance language server 2021.6.0
OS and version: Ubuntu 18.04
Python version (& distribution if applicable, e.g. Anaconda): 3.8.10

Error messages:

[Info  - 8:41:53 ] Pylance language server 2021.6.0 (pyright 209c8040) starting
[Info  - 8:41:53 ] Server root directory: /home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist
[Error - 8:41:54] Exception received when installing recursive file system watcher: TypeError [ERR_FEATURE_UNAVAILABLE_ON_PLATFORM]: The feature watch recursively is unavailable on the current platform, which is being used to run Node.js
Libzip Error: Not a zip archive
    at makeLibzipError (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipFS.js:149:29)
    at new m (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipFS.js:121:28)
    at getZipSync (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:784:28)
    at g.makeCallSync (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:665:21)
    at g.existsSync (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:232:21)
    at c.existsSync (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ProxiedFS.js:71:28)
    at r.existsSync (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ProxiedFS.js:71:28)
    at T.existsSync (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/src/common/fileSystem.ts:213:23)
    at t.PyrightFileSystem.existsSync (/home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/src/pyrightFileSystem.ts:63:29)
    at /home//.vscode-server/extensions/ms-python.vscode-pylance-2021.6.0/dist/pyright-internal/src/analyzer/service.ts:1027:53
[Info  - 8:44:34 PM] Connection to server got closed. Server will restart.

jakebailey · 2021-06-08T18:17:00Z

The next release includes a fix for this.

BrandonLWhite · 2021-06-09T17:04:53Z

Found this issue while searching for a solution to my Libzip Error: Not a zip archive error. In my particular project we have test cases for handling of corrupt zip files as well as files that have the extension .zip but are actually some other compression format. I narrowed it down to Pylance crashing on these test input files that it found in our ./tests/data/in/ directory.

Thanks for the quick fix, and I look forward to the next release.

jakebailey · 2021-06-09T23:09:12Z

This issue has been fixed in version 2021.6.1, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202161-9-june-2021

github-actions bot added the triage label Jun 4, 2021

jakebailey mentioned this issue Jun 4, 2021

Pylance Error #1398

Closed

judej added bug Something isn't working in backlog labels Jun 7, 2021

github-actions bot removed the triage label Jun 7, 2021

jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Jun 8, 2021

jakebailey mentioned this issue Jun 9, 2021

Python language server from Pylance is crashing #1417

Closed

jakebailey closed this as completed Jun 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Server crashes with Libzip Error #1397

Server crashes with Libzip Error #1397

johntmyers commented Jun 4, 2021

jakebailey commented Jun 4, 2021

johntmyers commented Jun 4, 2021

jakebailey commented Jun 4, 2021 •

edited

Loading

johntmyers commented Jun 4, 2021

erictraut commented Jun 4, 2021

jakebailey commented Jun 4, 2021

ducalpha commented Jun 7, 2021 •

edited

Loading

jakebailey commented Jun 8, 2021

BrandonLWhite commented Jun 9, 2021

jakebailey commented Jun 9, 2021

Server crashes with Libzip Error #1397

Server crashes with Libzip Error #1397

Comments

johntmyers commented Jun 4, 2021

Environment data

Expected behaviour

Actual behaviour

Logs

jakebailey commented Jun 4, 2021

johntmyers commented Jun 4, 2021

jakebailey commented Jun 4, 2021 • edited Loading

johntmyers commented Jun 4, 2021

erictraut commented Jun 4, 2021

jakebailey commented Jun 4, 2021

ducalpha commented Jun 7, 2021 • edited Loading

Environment data

Error messages:

jakebailey commented Jun 8, 2021

BrandonLWhite commented Jun 9, 2021

jakebailey commented Jun 9, 2021

jakebailey commented Jun 4, 2021 •

edited

Loading

ducalpha commented Jun 7, 2021 •

edited

Loading