-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server crashes with Libzip Error #1397
Comments
Interesting. Do you have any zip or egg files in your workspace, by chance? |
Yeah, always have because of some of the other tools we use that create various artifacts. This just started happening today though which is weird. |
The latest version of Pylance released on Wednesday adds support for zip/egg files, which the Python interpreter transparently opens when loading modules. That's probably why you're seeing this, and the initial workspace scan goes and explores them. It's likely that one of these files is malformed and we fail to access it. Perhaps it shouldn't try and do this inside of the workspace (only allowing eggs within site-packages), or at least limit to (The exists call also should not be throwing, which I can try and work around.) |
Ok, I'm not sure what new files would have gotten into my workspace in the last couple of days for this to stop working today. Also seems odd that the server doesn't actually start back up (contrary to the second to last log line) |
I think it's fine for the scan to open zips, but we need to have the appropriate exception handling in place so errors don't crash the language server. If a zip is malformed, we should just catch the exception and ignore the error. |
Yeah, |
I am getting the same problem and I have to downgraded Pylance to Environment dataLanguage Server version: Pylance language server 2021.6.0 Error messages:
|
The next release includes a fix for this. |
Found this issue while searching for a solution to my Thanks for the quick fix, and I look forward to the next release. |
This issue has been fixed in version 2021.6.1, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202161-9-june-2021 |
Environment data
Expected behaviour
The server should run
Actual behaviour
The server crashes, and does not properly restart
Logs
The text was updated successfully, but these errors were encountered: