Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python language server crashed by Libzip on 2021.6.1 #1421

Closed
FireBrother opened this issue Jun 10, 2021 · 4 comments
Closed

Python language server crashed by Libzip on 2021.6.1 #1421

FireBrother opened this issue Jun 10, 2021 · 4 comments
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@FireBrother
Copy link

Environment data

  • Language Server version: 2021.6.1
  • OS and version: macOS Catalina 10.15.7
  • Python version (& distribution if applicable, e.g. Anaconda): Miniconda Python 3.7.10 64-bit

Expected behaviour

It's expected to be fixed on 2021.6.1.

Actual behaviour

Still facing the same issue as #1417 with version of 6.1.

Logs

[Info  - 10:53:33 AM] Pylance language server 2021.6.1 (pyright e3f7cccc) starting
[Info  - 10:53:33 AM] Server root directory: /~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist
Libzip Error: Not a zip archive
    at makeLibzipError (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipFS.js:149:29)
    at new m (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipFS.js:121:28)
    at b.getZipSync (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:784:28)
    at b.makeCallSync (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:665:21)
    at b.readdirSync (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ZipOpenFS.js:582:21)
    at c.readdirSync (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ProxiedFS.js:191:28)
    at C.readdirSync (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/node_modules/@yarnpkg/fslib/lib/ProxiedFS.js:191:28)
    at I.readdirEntriesSync (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/src/common/fileSystem.ts:293:23)
    at t.PyrightFileSystem.processPartialStubPackages (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/src/pyrightFileSystem.ts:182:46)
    at _0x305a7e.ensurePartialStubPackages (/~/.vscode-server/extensions/ms-python.vscode-pylance-2021.6.1/dist/pyright-internal/src/analyzer/importResolver.ts:589:25)

Code Snippet / Additional information

XXX
@judej judej added bug Something isn't working in backlog labels Jun 10, 2021
@github-actions github-actions bot removed the triage label Jun 10, 2021
@jakebailey
Copy link
Member

Thanks for reporting; it seems like there are a few more cases for me to look at here.

@jakebailey
Copy link
Member

This should be fixed in the next release.

You should be able to roll back to 2021.5.4 if needed in the meantime, as it predates the zipfile support.

@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Jun 10, 2021
@bschnurr
Copy link
Member

This issue has been fixed in version 2021.6.2, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202162-16-june-2021

@FireBrother
Copy link
Author

Thanks for fixing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

4 participants