Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter hints not showing up when typing function parameters #1484

Closed
tddschn opened this issue Jun 21, 2021 · 9 comments
Closed

Parameter hints not showing up when typing function parameters #1484

tddschn opened this issue Jun 21, 2021 · 9 comments
Assignees

Comments

@tddschn
Copy link

tddschn commented Jun 21, 2021

Environment data

  • Language Server version: 2021.6.2
  • OS and version: darwin x64 (Intel)
  • Python version (and distribution if applicable, e.g. Anaconda): python 3.9.5 from conda-forge
  • python.analysis.indexing: undefined
  • python.analysis.typeCheckingMode: off

Expected behaviour

Showing parameter hints in a popup when typing a function's parameters, without cursor hovering over the function.

Actual behaviour

When using non standard library modules, I had to hover over the function to get the parameter hint.

Screen.Recording.2021-06-21.at.3.44.15.PM.mov

Logs

Python Language Server Log

Background analysis message: setFileOpened
Background analysis message: markFilesDirty
[FG] parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (12ms)
[FG] binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (2ms)
[FG] completion at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py:194:6 ...
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/function_base.pyi [fs read 1ms] (4ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/function_base.pyi (1ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/fromnumeric.pyi [fs read 0ms] (13ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/fromnumeric.pyi (1ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/_type_aliases.pyi [fs read 2ms] (2ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/_type_aliases.pyi (0ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/_ufunc_config.pyi [fs read 1ms] (3ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/_ufunc_config.pyi (0ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/numerictypes.pyi [fs read 1ms] (3ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/numerictypes.pyi (0ms)
[FG] completion at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py:194:6 [found 6 items] (33ms)
[FG] parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/__init__.py [fs read 0ms] (28ms)
[FG] binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/__init__.py ...
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/__init__.pyi [fs read 0ms] (1ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/core/__init__.pyi (0ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/__init__.pyi [fs read 0ms] (5ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/__init__.pyi (1ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/matrixlib/__init__.pyi [fs read 1ms] (2ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/matrixlib/__init__.pyi (0ms)
[FG] binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/__init__.py (11ms)
[FG] parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/__init__.py [fs read 2ms] (5ms)
[FG] binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/__init__.py ...
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/type_check.py [fs read 1ms] (20ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/type_check.py (1ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/index_tricks.py [fs read 3ms] (16ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/index_tricks.py (3ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/function_base.py [fs read 1ms] (45ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/function_base.py (12ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/nanfunctions.py [fs read 2ms] (16ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/nanfunctions.py (5ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/shape_base.py [fs read 2ms] (12ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/shape_base.py (2ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/stride_tricks.py [fs read 2ms] (6ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/stride_tricks.py (1ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/twodim_base.py [fs read 1ms] (7ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/twodim_base.py (2ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/ufunclike.py [fs read 1ms] (2ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/ufunclike.py (0ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/histograms.py [fs read 2ms] (11ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/histograms.py (3ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/polynomial.py [fs read 1ms] (16ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/polynomial.py (5ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/utils.py [fs read 1ms] (13ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/utils.py (4ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/arraysetops.py [fs read 2ms] (9ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/arraysetops.py (1ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/npyio.py [fs read 2ms] (27ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/npyio.py (11ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/arraypad.py [fs read 1ms] (9ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/arraypad.py (2ms)
[FG]   parsing: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/_version.py [fs read 2ms] (4ms)
[FG]   binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/_version.py (4ms)
[FG] binding: /usr/local/Caskroom/miniconda/base/lib/python3.9/site-packages/numpy/lib/__init__.py (275ms)
Background analysis message: analyze
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py ...
[BG(1)]   parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (9ms)
[BG(1)]   binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
[BG(1)]   checking: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (151ms)
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (161ms)
Background analysis message: getSemanticTokens full
[BG(1)] getSemanticTokens full at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/pyfiglet.ipynb (0ms)
Background analysis message: resumeAnalysis
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
[FG] parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (3ms)
[FG] binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
Background analysis message: analyze
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py ...
[BG(1)]   parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (19ms)
[BG(1)]   binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (5ms)
[BG(1)]   checking: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (112ms)
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (136ms)
Background analysis message: getSemanticTokens full
[BG(1)] getSemanticTokens full at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/pyfiglet.ipynb (0ms)
Background analysis message: resumeAnalysis
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
[FG] parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (3ms)
[FG] binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
Background analysis message: analyze
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py ...
[BG(1)]   parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (18ms)
[BG(1)]   binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
[BG(1)]   checking: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (102ms)
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (122ms)
Background analysis message: getSemanticTokens full
[BG(1)] getSemanticTokens full at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/pyfiglet.ipynb (0ms)
Background analysis message: resumeAnalysis
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
[FG] parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (2ms)
[FG] binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
[FG] completion at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py:194:11 [found 172 items] (30ms)
Background analysis message: setFileOpened
[FG] completion at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py:194:12 ...
[FG]   parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (2ms)
[FG]   binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (2ms)
[FG] completion at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py:194:12 [found 14 items] (27ms)
Background analysis message: markFilesDirty
Background analysis message: getSemanticTokens full
[BG(1)] getSemanticTokens full at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/pyfiglet.ipynb (0ms)
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
[FG] completion at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py:194:13 ...
[FG]   parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (5ms)
[FG]   binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
[FG] completion at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py:194:13 [found 2 items] (45ms)
Background analysis message: analyze
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py ...
[BG(1)]   parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (8ms)
[BG(1)]   binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
[BG(1)]   checking: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (90ms)
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (99ms)
Background analysis message: getSemanticTokens full
[BG(1)] getSemanticTokens full at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/pyfiglet.ipynb (0ms)
Background analysis message: resumeAnalysis
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
[FG] parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (5ms)
[FG] binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (2ms)
Background analysis message: analyze
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py ...
[BG(1)]   parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (13ms)
[BG(1)]   binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
[BG(1)]   checking: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (90ms)
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (104ms)
Background analysis message: getSemanticTokens full
[BG(1)] getSemanticTokens full at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/pyfiglet.ipynb (0ms)
Background analysis message: resumeAnalysis
Background analysis message: setFileOpened
Background analysis message: markFilesDirty
Background analysis message: analyze
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py ...
[BG(1)]   parsing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (9ms)
[BG(1)]   binding: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (1ms)
[BG(1)]   checking: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (76ms)
[BG(1)] analyzing: /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/_NotebookConcat_f6496a11803a4f0a8572806def587f62.py (86ms)
Background analysis message: getSemanticTokens full
[BG(1)] getSemanticTokens full at /Users/tscp/testdir/Modern-Python-Standard-Library-Cookbook/pyfiglet.ipynb (0ms)
Background analysis message: resumeAnalysis

Code Snippet / Additional information

import numpy as np
pv0 = np.array([0.  , 0.05, 0.05, 0.05, 0.05, 0.05, 1.05])
np.delete(pv0,  # expecting param hints when typing params
@jakebailey
Copy link
Member

Pylance supports this, it's up to the client to display it. In this case, Jupyter notebooks are an entirely different UI and the extension rewires things to make it work. It seems like signature help is one that isn't supported (or, has some bug), so I'll transfer this to their repo.

@jakebailey jakebailey transferred this issue from microsoft/pylance-release Jun 21, 2021
@DavidKutu
Copy link

Sorry for the trouble @tddschn. We do support this and I've been trying but are unable to repro the issue.
What version of the jupyter extension are you using? Our latest stable is v2021.6.999406279

@tddschn
Copy link
Author

tddschn commented Jun 21, 2021

@DavidKutu That's the version I was using too. :)

@tddschn
Copy link
Author

tddschn commented Jun 22, 2021

@jakebailey I just tried the snippet in a .py file, and param hints for np.delete still didn't show up, but param hinting do work for some numpy functions like np.hstack on my machine. (Same behavior in python scripts & notebooks)

@DavidKutu
Copy link

it might be that its still loading those hints

@tddschn
Copy link
Author

tddschn commented Jun 22, 2021

Hints for hstack showed up instantly, and they showed up for any functions (or other tokens) instantly if I hover over them.

@DavidKutu
Copy link

@jakebailey this looks like the behavior is the same in python files and notebooks. Do you have any insight?

@jakebailey
Copy link
Member

I can pull this back to pylance, but likely this is covered under #150; numpy has some odd types for some functions and they will be improving in a future release.

@jakebailey jakebailey transferred this issue from microsoft/vscode-jupyter Jun 22, 2021
@judej
Copy link
Contributor

judej commented Jun 22, 2021

Dupe of #150

@judej judej closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants