Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No highlighting when selecting a word. #1500

Closed
HongtaoYang opened this issue Jun 25, 2021 · 6 comments
Closed

No highlighting when selecting a word. #1500

HongtaoYang opened this issue Jun 25, 2021 · 6 comments
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@HongtaoYang
Copy link

Issue Type: Bug

Missing variable highlights when selecting a word. This happens with instance variables from my testing. See the following three screen shots. Only thevar in the __init__ was highlighted when the cursor was on that variable. More strangely, it doesn't even highlight the variable in the same method.

Screen Shot 2021-06-25 at 18 00 17

Screen Shot 2021-06-25 at 18 00 27

Screen Shot 2021-06-25 at 18 01 05

Extension version: 2021.6.3
VS Code version: Code 1.57.1 (507ce72a4466fbb27b715c3722558bb15afa9f48, 2021-06-17T13:28:32.912Z)
OS version: Darwin x64 19.6.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-1068NG7 CPU @ 2.30GHz (8 x 2300)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 32.00GB (0.22GB free)
Process Argv . --crash-reporter-id 94428f45-d8ae-489d-ad47-c989c48031bb
Screen Reader no
VM 0%
@jakebailey
Copy link
Member

I can reproduce this, thanks.

image

@judej judej added the bug Something isn't working label Jun 28, 2021
@github-actions github-actions bot removed the triage label Jun 28, 2021
@lapraswastaken
Copy link

Yep, I've got the same issue.

image

@jakebailey jakebailey added the needs investigation Could be an issue - needs investigation label Jul 6, 2021
@jakebailey
Copy link
Member

jakebailey commented Jul 8, 2021

This appears to be a regression introduced in 2021.6.2 as a part of a refactoring done to enable dictionary key completion; they both use the same code to track variable read/writes.

@picrots
Copy link

picrots commented Jul 9, 2021

+1 from me to hopefully move this to higher priority for fix. TQ

@jakebailey
Copy link
Member

@picrots I have a fix prepared for review which should make it for next week's release, so no worries there.

@jakebailey jakebailey added fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed needs investigation Could be an issue - needs investigation labels Jul 14, 2021
@bschnurr
Copy link
Member

This issue has been fixed in version 2021.7.3, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202173-14-july-2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

6 participants