Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol renaming does not work. #1517

Closed
L117 opened this issue Jul 1, 2021 · 6 comments
Closed

Symbol renaming does not work. #1517

L117 opened this issue Jul 1, 2021 · 6 comments

Comments

@L117
Copy link

L117 commented Jul 1, 2021

Describe the bug
When you open freestanding python file and try to rename symbol, nothing happens.

To Reproduce

  1. Create empty directory.
  2. Create empty python file inside it.
  3. Open it with your editor of choice (Tried with Visual Studio Code and Sublime Text 4).
  4. Type something like:
    def foo():
        pass
    
  5. Save it.
  6. Try to rename symbol by clicking on function name and choosing "Rename symbol" (VS Code).
  7. See a popup message "No result".

Expected behavior
Symbol gets renamed.

VS Code extension or command-line
Both? v2021.6.944021595

@erictraut
Copy link
Contributor

I'm not able to repro this problem.

RenameSymbol

@erictraut
Copy link
Contributor

Are you opening the directory or the file? You need to open a file to establish a workspace. Symbol rename happens within a workspace.

@erictraut
Copy link
Contributor

Since this isn't a core type checking feature, I'm going to transfer it to the pylance-release repo.

@erictraut erictraut transferred this issue from microsoft/pyright Jul 1, 2021
@github-actions github-actions bot added the triage label Jul 1, 2021
@L117
Copy link
Author

L117 commented Jul 1, 2021

I'm opening a file, not a directory.
Oh, I should have mentioned: I'm using Fedora 34, not Windows.
Here's a video https://0x0.st/-fPD.mkv . Sorry for mkv.

@bschnurr
Copy link
Member

bschnurr commented Jul 5, 2021

thank you for the report.
Yes we are aware open file mode is lacking in some features.

@github-actions github-actions bot removed the triage label Jul 5, 2021
@jakebailey
Copy link
Member

This is a duplicate of #1300.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants