-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
While on Live Share, docstring quotes always auto-inserted at host's cursor #1583
Comments
These quotes are filled in by pylance. So I will move this issue over to Pylance for investigation. |
This one is interesting; I don't know if the event stream indicates who is the one typing... |
I should be able to fix this by not using the cursor at all, but instead use the location of the typing. |
This issue has been fixed in version 2021.7.5, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202175-22-july-2021 |
@jakebailey, good news and bad news. Good news: The original bug was fixed. Docstring quotes are now inserted at the remote cursor instead of at the host. Would you like me to submit a new issue for that? |
Ugh, so close. Do file a new issue and we can continue there. I'm a bit at a loss of how to prevent that. VS Code text edits are really finnicky when they are at the cursor. Best would be for VS Code to support multi-character auto-close itself, rather than me implementing it. |
Opened ticket #1592 |
TL;DR: On Live Share, if a remote machine types three quotes, a matching set of three quotes appears at the host machine's terminal instead of the remote machine.
First reported in: microsoft/vscode#127910 (comment)
Check there for additional details.
Environment data
Host machine:
python.languageServer
setting: default, which is I think pylanceRemote machine:
Expected behaviour
While using Live Share, if one of the participants types quote (
"
) three times to create a docstring, the other three quotes should appear at their cursor.Actual behaviour
The second set of three quotes appears at the host's cursor. See full description in: microsoft/vscode#127910 (comment).
The issue was moved to the live-share repo: microsoft/live-share#4353.
Steps to reproduce:
The text was updated successfully, but these errors were encountered: