Function named constructor breaks linting.

[bijij]

Having a function named constructor seemingly breaks linting, is pylance thinking this is a keyword?

Environment data

• Language Server version: 2021.7.6
• OS and version: Win 11
• Python version (& distribution if applicable, e.g. Anaconda): N/A but 3.9

Expected behaviour

Nothing would happen.

Actual behaviour

Code Snippet / Additional information

def constructor():
    ...

[jakebailey]

I can reproduce this; might be related to the recent parser change to disallow certain keywords as attribute changes, but those parts of the parser should have been separate.

[jakebailey]

The fix for keywords in attribute accesses exposed another bug.

microsoft/pyright@d9a66af

The old code disallowed specific keywords, then converted the others to identifiers. Now, it bans all keywords, which revealed that the tokenizer was accessing an object with the string "constructor", which returns the JS object constructor, rather than failing. I'm preparing a fix.

[jakebailey]

We've just released a hotfix (2021.7.7) which should fix this. Thanks for the issue!