Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No strict candidate in the completion list in zip #1912

Closed
Molkree opened this issue Oct 7, 2021 · 2 comments
Closed

No strict candidate in the completion list in zip #1912

Molkree opened this issue Oct 7, 2021 · 2 comments
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@Molkree
Copy link

Molkree commented Oct 7, 2021

Environment data

  • Language Server version: v2021.10.0
  • OS and version: Win10
  • Python version (& distribution if applicable, e.g. Anaconda): 3.10

Expected behaviour

strict is being suggested in the completions list.

Actual behaviour

image

Code Snippet / Additional information

Try typing strict inside zip.

names = ["John", "Jess"]
ages = [20]
for name, age in zip(names, ages):
    pass

Originally noticed in #1909

@github-actions github-actions bot added the triage label Oct 7, 2021
@Molkree Molkree changed the title No strict candidate in the completion provider in zip No strict candidate in the completion list in zip Oct 7, 2021
@judej judej added the needs investigation Could be an issue - needs investigation label Oct 7, 2021
@github-actions github-actions bot removed the triage label Oct 7, 2021
@erictraut
Copy link
Contributor

This will be addressed in the next release. The signature help logic was looking for an __init__ method and always preferring it over __new__. The zip class defines no __init__ method, so the __init__ method for object was being used instead. The new logic prefers the __new__ method if the only __init__ that is found is inherited from object.

@erictraut erictraut added fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed needs investigation Could be an issue - needs investigation labels Nov 3, 2021
@heejaechang
Copy link
Contributor

fixed in 2021.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

4 participants