-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*args type checking #20
Comments
Yes, I'll likely clone this to check for myself, as this codebase seems to be very annotated (yay!), but if you remove that |
This is definitely a bug in pyright/pylance. I'm debugging it now. In some code path (not yet determined) it's not treating the type of |
When I said "should have type |
Great, I see, thanks |
I found and fixed the bug and added some additional unit tests. It will be fixed in the next release. Thanks again for the bug report. |
Thank you! Feel free to close! |
This issue has been fixed in version 2020.7.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#202070-9-july-2020 |
Environment data
Expected behaviour
@jakebailey suggested I open a new issue based on #15 (comment)
From that issue:
I'm not sure this is correct. mypy & the pep seems fairly explicit that
*args: Hashable
should expect each of the args toHashable
, notargs
itself to beHashable
:https://www.python.org/dev/peps/pep-0484/#arbitrary-argument-lists-and-default-argument-values
Copying the requested screenshot from the attached issue for convenience
![image](https://user-images.githubusercontent.com/5635139/86285757-0915c200-bb9a-11ea-98e4-f413890299e1.png)
Let me know if logs etc would be helpful.
Thank you!
The text was updated successfully, but these errors were encountered: