-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make optional the Intellisense offer of super()-calls when overwriting inherited methods #2531
Comments
This doesn't seem like a good candidate for a setting. It's not really a personal preference, but rather something that is contextual. The same user might want it in some cases but not in others. Switching a setting between these cases would be cumbersome. In cases where you don't want to call through to the base class method, why not simply overwrite the code when you add the actual implementation? |
It may be tedious to always remove the But it is really just one line that we have to always remove in the methods. So, maybe you're right and it is not worth it. BTW, switching a specific setting so often is not so cumbersome when we install this extension. |
What code would you want pylance to emit when the base method is abstract? The method requires at least one statement in its implementation to avoid a syntax error. Would you prefer that it emit |
You're right. I was thinking about "no emission at all", as we always have to implement something in abstract methods, But the Sorry to bother you with that. |
The feature of intellisense offering
super()
-calls when overwriting inherited methods is very useful (requested in #668).But can it remain as optional? (activated in settings)
Because sometimes we may don't want to add the
super
call.Like when implementing interfaces/abstract classes, for instance, as in this example.
The text was updated successfully, but these errors were encountered: