Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show document of callable objects doesn't works when "python.autoComplete.addBrackets" is on. #273

Closed
byehack opened this issue Aug 22, 2020 · 5 comments
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@byehack
Copy link

byehack commented Aug 22, 2020

Environment data

  • Language Server version: XXX
  • OS and version: XXX
  • Python version (& distribution if applicable, e.g. Anaconda): XXX

Expected behaviour

show args of print function after write pr and enter with "python.autoComplete.addBrackets" enable.

Actual behaviour

XXX

Logs

XXX

Code Snippet / Additional information

XXX
@savannahostrowski
Copy link
Contributor

Hey there. You should use the new python.analysis.completeFunctionParens to enable this functionality in Pylance.

If there is another issue with this feature, can you please provide more details?

@jakebailey jakebailey added the enhancement New feature or request label Aug 24, 2020
@github-actions github-actions bot removed the triage label Aug 24, 2020
@jakebailey
Copy link
Member

Assuming this is the signature help that shows up when () is typed, it doesn't work because VS Code doesn't trigger it until the user types (, ), or ,, and with the snippet that adds the parens, the user's not typing it anymore.

We'd need a way to force VSC to run editor.action.triggerParameterHints when the completion item is selected, which could be done via a command, but we have other uses for commands and can't send more than one. Or, the LSP needs an extension to allow us to ask the client to immediately request the hints.

@byehack
Copy link
Author

byehack commented Aug 26, 2020

Hey there. You should use the new python.analysis.completeFunctionParens to enable this functionality in Pylance.

If there is another issue with this feature, can you please provide more details?

still now working.

@byehack byehack closed this as completed Aug 26, 2020
@byehack byehack reopened this Aug 26, 2020
@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Sep 2, 2020
@jakebailey
Copy link
Member

I found a relatively clean way to handle this. The next release will open the signature help when one of these completion items is selected.

@jakebailey
Copy link
Member

This issue has been fixed in version 2020.9.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#202090-3-september-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

3 participants