Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completions for kwargs showing while in the middle of a string #383

Closed
savannahostrowski opened this issue Sep 17, 2020 · 2 comments
Closed
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@savannahostrowski
Copy link
Contributor

Environment data

  • Language Server version: 2020.9.5
  • OS and version: Windows, VSCode version 1.49
  • Python version (& distribution if applicable, e.g. Anaconda): 3.8.5

Expected behaviour

I don't get completions while in the middle of typing out a string-type param.

Actual behaviour

If I type "." while in a string-type param while invoking a function, I get a completion list of kwargs.
bug_function_invocation

@jakebailey
Copy link
Member

This is related to #163, though we don't want to eliminate completions in strings in the context of type annotations.

@jakebailey jakebailey added bug Something isn't working needs investigation Could be an issue - needs investigation labels Sep 18, 2020
@github-actions github-actions bot removed the triage label Sep 18, 2020
@jakebailey jakebailey added fixed in next version (main) A fix has been implemented and will appear in an upcoming version and removed needs investigation Could be an issue - needs investigation labels Nov 11, 2020
@jakebailey
Copy link
Member

This issue has been fixed in version 2020.11.1, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#2020111-11-november-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

2 participants