Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas to_datetime does not accept origin=Timestamp argument #428

Closed
Dr-Irv opened this issue Sep 26, 2020 · 1 comment
Closed

pandas to_datetime does not accept origin=Timestamp argument #428

Dr-Irv opened this issue Sep 26, 2020 · 1 comment
Assignees
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version typestub Issue relating to our bundled type stubs

Comments

@Dr-Irv
Copy link

Dr-Irv commented Sep 26, 2020

Environment data

  • Language Server version: 2020.9.6
  • OS and version: Windows 10
  • Python version (& distribution if applicable, e.g. Anaconda): Anaconda Python 3.7.5

Expected behaviour

No error

Actual behaviour

print(pd.to_datetime([1, 2, 3], unit="D", origin=pd.Timestamp("1960-01-01")))

reports (once the fix suggested from #427 is applied):

Argument of type "Timestamp" cannot be assigned to parameter "origin" of type "str" in function "to_datetime"
  "Timestamp" is incompatible with "str"

Fix is:

diff core/tools/datetimes.pyi.ORIG core/tools/datetimes.pyi
4a5
> from pandas._libs.tslibs import Timestamp
12c13
< def to_datetime(arg, errors: str = ..., dayfirst: bool = ..., yearfirst: bool = ..., utc = ..., format = ..., exact: bool = ..., unit = ..., infer_datetime_format: bool = ..., origin: str = ..., cache: bool = ...): ...
---
> def to_datetime(arg, errors: str = ..., dayfirst: bool = ..., yearfirst: bool = ..., utc = ..., format = ..., exact: bool = ..., unit = ..., infer_datetime_format: bool = ..., origin: Union[str, Timestamp] = ..., cache: bool = ...): ...
@jakebailey jakebailey added the typestub Issue relating to our bundled type stubs label Sep 26, 2020
@github-actions github-actions bot removed the triage label Sep 26, 2020
@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Oct 2, 2020
@jakebailey
Copy link
Member

This issue has been fixed in version 2020.10.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#2020100-7-october-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next version (main) A fix has been implemented and will appear in an upcoming version typestub Issue relating to our bundled type stubs
Projects
None yet
Development

No branches or pull requests

3 participants