Semantic Highlighting issues with Type Hints for Generic Types

[hassanselim0]

Environment data

• Language Server version: 2020.9.8
• OS and version: Windows 10 v2004
• Python version: Python 3.8.2

Expected behaviour

Given this function definition:

def calc(nums: List[int]):
    pass

The entire List[int] span should have the typeHint semantic modifier.

Actual behaviour

(note: I've overridden the token color for *.typeHint to red for clarity)

List gets the variable semantic without the typeHint modifier.

The square brackets don't get any semantic token or modifier.

Edit: It seems like these issues happen on class variable annotations too, not just in function argument annotations.

Code Snippet / Additional information

Related Feature Request: #335

[hassanselim0]

Just found something that could narrow down this issue:

The semantic token type for all these types is class, except for Dict which is variable. So the problem could be that the typeHint modifier currently only applies to classes and not variables, even though variables can contain type objects.

[huguesv]

Thanks for the report. We should be able to fix those.

[jakebailey]

This issue has been fixed in version 2020.10.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#2020100-7-october-2020

[hassanselim0]

Thank you, I just updated and the problem is fixed.
The square brackets still don't get any token though, which I think means they can't get the typeHint modifier.
I'm not sure if it would be worth the effort though. My main purpose with the original feature request is to make the type hints less eye-catching and not stand out (currently trying out faded colors), to try and keep the code as readable as possible.
For me, what we have now is a good step and I would consider myself satisfied.

For reference, these are the colors customizations I'm experimenting right now with the Amethyst Dark theme:

(this screenshot it part of a Pydantic Data Model, a typing library that I've started using a lot in the past month)