Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO means NO - stop prompting to make pylance the default language server #568

Closed
ghost opened this issue Nov 5, 2020 · 8 comments
Closed
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version

Comments

@ghost
Copy link

ghost commented Nov 5, 2020

59810abc21000025a7fc9b6b

Expected behaviour

Snipaste_2020-11-05_10-53-17

I know that microsoft has a history of disrepcting user choices, and agressively pushing microsoft defaults into users even when users said "no", but this is getting extremely annoying on my text editor.

Once a user confirms that it does not want to make Pylance the default language server, you should never prompt it again.
Not even if pylance is updated.
Not even if I open a new folder.
Not even if I open a new file.

Once I said "no, thanks" it's pretty clear that I don't want to make pylance the default language server.

Actual behaviour

Randomly, when user opens a new folder, or python file, or updates the extension, Pylance will annoy the user prompting to make it the default language server.

@github-actions github-actions bot added the triage label Nov 5, 2020
@jakebailey
Copy link
Member

jakebailey commented Nov 5, 2020

This prompt will appear if Pylance is installed but not set as the language server. If you aren't intending on using it, can you uninstall the extension? Or are you looking to only use it for some workspaces and not others?

It's also likely that we can stop resetting things on update; in preview the intent was to ensure nobody is stranded thinking they have it working when they don't. We're not trying to make it annoying.

@jakebailey jakebailey added the waiting for user response Requires more information from user label Nov 5, 2020
@github-actions github-actions bot removed the triage label Nov 5, 2020
@ghost
Copy link
Author

ghost commented Nov 5, 2020

@jakebailey I installed it because intellicode - and intellicode is helpful with other languages, not just with python - and python for vscode will spam me to death with notifications If I don't.
Even if I intended to only enable it for "some" workspaces, the prompt would still be wrong because it would change the global language server, not only the settings for the local workspace.

@ghost
Copy link
Author

ghost commented Nov 5, 2020

@jakebailey I also have "python.languageServer": "Jedi" on my settings, which makes it pretty clear that I don't want the closed source pylance enabled.
If you're not trying to make it annoying like other microsoft programs that ignore user default preferences, then why not respect the prompt?

@jakebailey jakebailey added bug Something isn't working in backlog and removed waiting for user response Requires more information from user labels Nov 5, 2020
@jakebailey
Copy link
Member

We'll switch our prompt to ensure that clicking "no" never shows it again.

If I'm understanding this correctly, the reason for installing Pylance is just to make the IntelliCode extension not pop up as well; their prompt unfortunately does not have a "no" setting, but we can go see about getting that added as that's a better solution to this than installing an extension you don't plan to use.

@ghost
Copy link
Author

ghost commented Nov 5, 2020

@jakebailey Yes, it would be helpful to fix it in intellicode as well! Thanks!

@jakebailey jakebailey added the fixed in next version (main) A fix has been implemented and will appear in an upcoming version label Nov 5, 2020
@beauxq
Copy link

beauxq commented Nov 5, 2020

I haven't tried yet, but I'm interested in being able to use it for some workspaces and not others.

Is this possible? How is it configured?

@jakebailey
Copy link
Member

You can set python.languageServer within your folder/workspaces's settings.json, and it will be applied for that editor session.

@jakebailey
Copy link
Member

This issue has been fixed in version 2020.11.1, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/master/CHANGELOG.md#2020111-11-november-2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in next version (main) A fix has been implemented and will appear in an upcoming version
Projects
None yet
Development

No branches or pull requests

2 participants