Stub files - Auto-import shown for already imported symbols

[cdce8p]

Environment data

• Language Server version: 2020.12.0
• OS and version: macOS
• Python version: 3.9

Expected behaviour

The Auto-import note should not be displayed for symbols which are already imported.

Actual behaviour

Code Snippet / Additional information

From my testing, this seem to affect only stub files.

from typing import Union

Union

--

Same example in a normal python file

[heejaechang]

@cdce8p can you give me more context/repro on this? creating blank a.py file and testing it doesn't repro it so it feels like it requires some setup to repro?

[cdce8p]

@heejaechang I can still reproduce the error with pylance 2021.3.1 in an empty project. However, as stated in the title and description, this only happens for stub files .pyi. Normal .py files are fine which I find a bit curious.

Here is what I did:

1. Create a new folder
2. Create a.pyi with

from typing import Union

3. Start typing: Union in a new line and activate autocompletion

My folder settings:

{
    "python.languageServer": "Pylance",
    "python.analysis.typeCheckingMode": "strict",
}

[jakebailey]

I experienced this when I was working on the matplotlib stubs last week; I think the completion provider is using the wrong symbol table when offering completions within stubs, using the one that contains symbols externally visible to other files, and not the table that is internally visible to the stub itself.

In the above example, Union is not externally visible to importers of a.pyi. I bet if that line were changed to from typing import Union as Union (which is not the right thing to do except to test the theory), it'd work, as the Union symbol would appear to be externally visible.

[jakebailey]

This issue has been fixed in version 2021.3.2, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202132-17-march-2021