Type info of decorated class is not helpful with specific attribute class

[kang-sw]

When gin.configurable decorates any class, pylance's suggestions shows pretty useless information. It works well when the class is decorated with attr.attrs, or any other attribute method.

This makes it hard to work with tf-agents that most of classes are decorated with gin attribute....

Is there any workaround to resolve this?

[jakebailey]

This is likely due to the gin.configurable decorator not being well-typed, and the analysis assuming it wipes away all of the info. This happens pretty commonly when a decorator uses functools.wraps, whose type isn't super helpful.

Where can we find the code for gin? I've looked on PyPI, but the results didn't seem like they matched what this library appears to be doing.

[kang-sw]

I found this when I was using tf-agent library to practice some reinforcement algorithms.

I think you can get gin package by command pip install gin, in Windows.

and here's url of the repository gin

[jakebailey]

Yeah, they haven't annotated it at all: https://github.com/google/gin-config/blob/0841fef568722a21e4f3745a0697da608ba4376e/gin/config.py#L1163

Though I'm a bit confused, as I believe we had a heuristic where we would assume that the decorator did nothing to the signature if the decorator was untyped. @erictraut Am I misremembering that?

[erictraut]

That's definitely the way it used to work. I'm wondering if maybe I broke that heuristic when I added support for PEP 614. I don't think we have a specific unit test for this heuristic, and we probably should.

[erictraut]

This will be addressed in the next release. See microsoft/pyright#1292 for details.

[jakebailey]

This issue has been fixed in version 2021.1.0, which we've just released. You can find the changelog here: https://github.com/microsoft/pylance-release/blob/main/CHANGELOG.md#202110-6-january-2021