Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): declare support for react-native-windows 0.71 #1254

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 4, 2023

Description

Declare support for react-native-windows 0.71

Platforms affected

  • Android
  • iOS
  • macOS
  • Windows

Test plan

npm run set-react-version 0.71
yarn
cd example
yarn install-windows-test-app
yarn windows

While the app is building, open a new terminal and start the dev server:

yarn start

Note that there seems to be some indexing issues with Metro 0.73.5. If you're getting errors on startup, try explicitly disabling Watchman:

diff --git a/example/metro.config.js b/example/metro.config.js
index 12bc144..47a96e3 100644
--- a/example/metro.config.js
+++ b/example/metro.config.js
@@ -38,6 +38,7 @@ module.exports = {
   resolver: {
     blacklistRE: blockList,
     blockList,
+    useWatchman: false,
   },
   transformer: {
     getTransformOptions: async () => ({

Screenshots

image

@tido64 tido64 requested review from afoxman and kelset January 4, 2023 14:59
@github-actions github-actions bot added the platform: Windows This affects Windows label Jan 5, 2023
@tido64 tido64 marked this pull request as ready for review January 19, 2023 09:22
@tido64 tido64 merged commit 908d452 into trunk Jan 20, 2023
@tido64 tido64 deleted the tido/rnw-0.71 branch January 20, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants