Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(apple): fix crash on startup on 0.75 + New Arch #2127

Merged
merged 1 commit into from
Jul 17, 2024
Merged

fix(apple): fix crash on startup on 0.75 + New Arch #2127

merged 1 commit into from
Jul 17, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jul 16, 2024

Description

Fix crash on startup on 0.75 + New Arch caused by accessing ReactNativeFeatureFlags before overrides are set.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run set-react-version 0.75 -- --core-only
yarn
cd example
RCT_NEW_ARCH_ENABLED=1 pod install --project-directory=ios
yarn ios

# In a separate terminal
yarn start

@tido64 tido64 mentioned this pull request Jul 16, 2024
Closed
30 tasks
@github-actions github-actions bot added platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS labels Jul 16, 2024
@tido64 tido64 merged commit 6debf33 into trunk Jul 17, 2024
30 checks passed
@tido64 tido64 deleted the tido/ios/fix-bridgeless-startup branch July 17, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonVMo JasonVMo JasonVMo approved these changes

@Saadnajmi Saadnajmi Awaiting requested review from Saadnajmi Saadnajmi is a code owner

Assignees
No one assigned
Labels
platform: iOS This affects iOS platform: macOS This affects macOS platform: visionOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @JasonVMo