Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare support for 0.75 #2128

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix: declare support for 0.75 #2128

merged 2 commits into from
Aug 1, 2024

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jul 16, 2024

Description

Declare support for 0.75.

Resolves #1901.

Platforms affected

  • Android
  • iOS
  • macOS
  • visionOS
  • Windows

Test plan

npm run test:matrix 0.75
Configuration JSC Hermes Fabric Fabric + Hermes
Android n/a Screenshot-Android-hermes n/a Screenshot-Android-hermes-fabric-concurrent
iOS Screenshot-iOS Screenshot-iOS-hermes Screenshot-iOS-fabric-concurrent Screenshot-iOS-hermes-fabric-concurrent
visionOS image n/a n/a n/a
Windows n/a image n/a n/a

@github-actions github-actions bot added platform: Android This affects Android platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Jul 16, 2024
@tido64
Copy link
Member Author

tido64 commented Jul 16, 2024

0.75.0-rc.5

Android: Crash on startup:

/__w/react-native/react-native/packages/react-native/ReactCommon/jsi/jsi/jsi-inl.h:187: std::shared_ptr<T> facebook::jsi::Object::getHostObject(Runtime &) const [T = facebook::react::RuntimeSchedulerBinding]: assertion "isHostObject<T>(runtime)" failed

Fails only on 0.75. Nightly (0.76.0-nightly-20240715-2eb7bcb8d) is fine.

Screenshot

Screenshot_1721127399

Potentially fixed in rc.6: facebook/react-native@2098806

@github-actions github-actions bot removed platform: iOS This affects iOS platform: macOS This affects macOS platform: Windows This affects Windows platform: visionOS labels Jul 17, 2024
@github-actions github-actions bot added platform: Windows This affects Windows and removed platform: Android This affects Android labels Jul 22, 2024
@matthargett
Copy link

@okwasniewski can you publish a 0.75 RC release of visionOS so this matrix can get filled with an Apple OOT platform?

@tido64
Copy link
Member Author

tido64 commented Jul 30, 2024

0.75.0-rc.6

All good. Android crash has been fixed.

@okwasniewski
Copy link
Contributor

@okwasniewski can you publish a 0.75 RC release of visionOS so this matrix can get filled with an Apple OOT platform?

I've released the first RC of RN visionOS today. Thanks for great workon this @tido64

@tido64
Copy link
Member Author

tido64 commented Jul 30, 2024

I've released the first RC of RN visionOS today.

I'm testing this right now (though you're welcome to try it out as well). I've noticed that you're using a newer scheduler version (0.25.0-rc-fb9a90fa48-20240614 vs 0.24.0-canary-efb381bbf-20230505). Is that intentional?

@okwasniewski
Copy link
Contributor

I've released the first RC of RN visionOS today.

I'm testing this right now (though you're welcome to try it out as well). I've noticed that you're using a newer scheduler version (0.25.0-rc-fb9a90fa48-20240614 vs 0.24.0-canary-efb381bbf-20230505). Is that intentional?

Ah, that must be a mistake on my side - not sure when it got in because I didn't change anything related to this 🤔 I will check the diffs between 0.75-stable upstream and visionOS

@tido64 tido64 marked this pull request as ready for review July 30, 2024 17:42
@tido64 tido64 requested a review from Saadnajmi July 30, 2024 17:42
@tido64
Copy link
Member Author

tido64 commented Aug 1, 2024

@matthargett, @okwasniewski: 0.75.0-rc.2-visionos seems to be building fine so I will include it in this PR.

@tido64 tido64 enabled auto-merge (squash) August 1, 2024 17:18
@tido64 tido64 merged commit 04090d7 into trunk Aug 1, 2024
30 checks passed
@tido64 tido64 deleted the tido/0.75 branch August 1, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: Windows This affects Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for react-native 0.75
4 participants